unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: contovob@tcd.ie, 61637@debbugs.gnu.org
Subject: bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER
Date: Sat, 04 Mar 2023 17:04:25 +0200	[thread overview]
Message-ID: <83mt4sa77q.fsf@gnu.org> (raw)
In-Reply-To: <87jzzw646j.fsf@gmail.com> (message from João Távora on Sat, 04 Mar 2023 13:23:32 +0000)

> From: João Távora <joaotavora@gmail.com>
> Cc: contovob@tcd.ie,  61637@debbugs.gnu.org
> Date: Sat, 04 Mar 2023 13:23:32 +0000
> 
> > You disregarded the second part of my reasoning, which has to do with
> > the test results being non-deterministic once the user's real home
> > directory is accessible to Emacs.  How do we overcome that?
> 
> Sorry I didn't mean to disregard, I just missed it.  Well, it's not
> accessible to Emacs, only to LSP servers.  Eglot's tests are fairly are
> deterministic, all other things like LSP server versions being equal.
> 
> I'd say Eglot's tests are even robust to any changes in LSP server's
> user init files.  See how XDG_CONFIG_HOME is spooffed in eglot-tests.el
> to this effect.  It has been effective AFAICT for some time.  And that's
> only for those few servers that do offer these mechanisms: most of them
> rely on project-local configurations which is fine because Eglot creates
> a temporary project for each test.
> 
> All in all, I think the problem of user file clobbering and determinism
> are exaggerated -- in this specific case of course.  They are secondary
> to the fact that it's tricky, noisy, or even impossible to run Eglot
> tests ever since Eglot moved to Emacs core.  
> 
> I propose we install my patch and then perfect the solution.  Again,
> we're only affecting those devs who _do_ have these local installations,
> and that affection is much, much more likely to be beneficial than
> harmful.

OK, please go ahead, and thanks.





  reply	other threads:[~2023-03-04 15:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-19 19:10 bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 19:38 ` João Távora
2023-02-20  9:22   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20  9:30     ` João Távora
2023-02-20 13:02     ` Eli Zaretskii
2023-03-04  1:04       ` João Távora
2023-03-04  7:46         ` Eli Zaretskii
2023-03-04 11:48           ` João Távora
2023-03-04 12:46             ` Eli Zaretskii
2023-03-04 13:23               ` João Távora
2023-03-04 15:04                 ` Eli Zaretskii [this message]
2023-03-04 17:21                 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 19:35                   ` João Távora
2023-03-04 17:28               ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 19:22                 ` João Távora
2023-04-10 10:09                   ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 17:20             ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 17:26           ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 19:19             ` João Távora
2023-03-04 17:19         ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 18:09           ` Eli Zaretskii
2023-03-04 19:27             ` João Távora
2023-03-04 19:25           ` João Távora
2023-02-20 13:01 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mt4sa77q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61637@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).