From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62420: 29.0.60; fns-tests-collate-strings fails on Cygwin Date: Sat, 25 Mar 2023 15:24:29 +0300 Message-ID: <83mt41c936.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62420@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 13:25:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg2xS-000ANR-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 13:25:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg2xI-0007nS-Db; Sat, 25 Mar 2023 08:25:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2xD-0007ms-Vx for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:25:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg2xD-0004bU-Fm for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg2xC-0004rQ-AG for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62420 X-GNU-PR-Package: emacs Original-Received: via spool by 62420-submit@debbugs.gnu.org id=B62420.167974708918653 (code B ref 62420); Sat, 25 Mar 2023 12:25:02 +0000 Original-Received: (at 62420) by debbugs.gnu.org; 25 Mar 2023 12:24:49 +0000 Original-Received: from localhost ([127.0.0.1]:42017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2wv-0004qk-Cs for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:24:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2wp-0004qD-GH for 62420@debbugs.gnu.org; Sat, 25 Mar 2023 08:24:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2wj-0004Wb-Py; Sat, 25 Mar 2023 08:24:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=97RNjaa6egvDSJIxfR1uSxQzdx7eEEREn3GwXXxLd1k=; b=al4dRHbbs0dN biZ/4+czPbqDMbRY/XUBh2fiNeZy2EENoZVkJ4GFdqsUqGJG0IF49r1S2128yKB4DLO2iqY8c6voW o9nmmd12Jn9ul99C1LIEQb54eIl+HiZcAQOPP+9oxMcsnPdv2UzxDs8s9Wom+TkjyINki3EFsryZ9 ekVdFYDV2pvXajxOX1CvItFiBN/olOm5GRG9gAx7AXOOje70SZZxENHn870M7V9nyskfq1FOXnL1f vHPP9/Cehi+y0deBc0YI0tKNNBdfnUKpCEI1cSRZnAZalZNWoLI3fDdlckMMhxgujEYzP1pcT8/uO 2tJt1SomssPvgxMLqJEu5g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2wi-0002jf-72; Sat, 25 Mar 2023 08:24:32 -0400 In-Reply-To: (message from Ken Brown on Fri, 24 Mar 2023 10:52:45 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258550 Archived-At: > Date: Fri, 24 Mar 2023 10:52:45 -0400 > From: Ken Brown > > The reason is that en_DE.UTF-8 is actually a valid locale on Cygwin. > [Cygwin gets its locale information from Windows. The latter supports > the RFC 5646 locale "en-DE", which is called "English (Germany)" in the > "Region" settings.] > > The following trivial patch fixes the problem: > > --- a/test/src/fns-tests.el > +++ b/test/src/fns-tests.el > @@ -254,7 +254,7 @@ fns-tests-collate-strings > (should (string-collate-equalp "xyzzy" "XYZZY" nil t)) > ;; Locale must be valid. > - (should-error (string-collate-equalp "xyzzy" "xyzzy" "en_DE.UTF-8"))) > + (should-error (string-collate-equalp "xyzzy" "xyzzy" "en_XY.UTF-8"))) > ;; There must be a check for valid codepoints. (Check not > implemented yet) > ; (should-error > > > Is this OK for the emacs-29 branch? Yes, thanks. > [Note: The test will still fail on current Cygwin after this patch; but > that's because of a bug in Cygwin, which has been fixed in the > development sources for Cygwin 3.5.] Maybe mention this in comments? Bonus points for making it an expected failure for Cygwin < 3.5, assuming the version of Cygwin could be obtained by the test code.