From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Date: Thu, 30 Mar 2023 17:31:40 +0300 Message-ID: <83mt3u48fn.fsf@gnu.org> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> <83wn2y6caq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25258"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 62429@debbugs.gnu.org, monnier@iro.umontreal.ca To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 30 16:32:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phtK4-0006LU-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Mar 2023 16:32:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phtJs-0005sa-5k; Thu, 30 Mar 2023 10:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phtJq-0005sP-OW for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 10:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phtJq-0003qt-5z for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 10:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phtJq-0000yI-0y for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 10:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs Original-Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.16801867003706 (code B ref 62429); Thu, 30 Mar 2023 14:32:01 +0000 Original-Received: (at 62429) by debbugs.gnu.org; 30 Mar 2023 14:31:40 +0000 Original-Received: from localhost ([127.0.0.1]:59172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phtJT-0000xh-Lu for submit@debbugs.gnu.org; Thu, 30 Mar 2023 10:31:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phtJR-0000xT-VG for 62429@debbugs.gnu.org; Thu, 30 Mar 2023 10:31:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phtJL-0003pC-9L; Thu, 30 Mar 2023 10:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Ptz7DtPONMeiju8ato95y1Fbd4QwnXKP8phlGFWXhw0=; b=O7zVLO5co7eWnaIrndVG O54QhWDIFjJt70vEV6dReQGXaJfmtOiMolq2URAT4L8ygzOJ1v1sUmXhMrTJ5+RegDWp1DhGaqN4v 9I48MtUQWkWSpn+cunfXWtoKmiAKzsldwcs2boG/I68ZROFOex4VdmQhvoyDwaP8VVsJdsv/j0qQM Pxmopt0EbvP9kvyuPDBkcqb0RgYh8TdRD32XpXMriwn9kqpQ9Azlevif991KjlEP/PLUfb/A13y8Q yFQlDNXjb5AyO2U0QR2Stsfh0uL/cTOc5GVudrkrOMJUXl2blAYLpXKOcNPbGqKdfXOWaahtcMps6 jzxRojapC9FsVg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phtJK-0000gt-2d; Thu, 30 Mar 2023 10:31:30 -0400 In-Reply-To: (message from Yuan Fu on Thu, 30 Mar 2023 01:11:48 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258930 Archived-At: > From: Yuan Fu > Date: Thu, 30 Mar 2023 01:11:48 -0700 > Cc: Stefan Monnier , > 62429-done@debbugs.gnu.org, > theodor thornhill > > >>> OK, but then how will these JSX-specific faces fit into the overall > >>> scheme of treesit-font-lock faces? For example, in what level will > >>> they be used, and how will users know what level to set to see these > >>> faces in their buffers? > >> > >> At level 3 for tsx-ts-mode, under the “jsx” feature. So they are enabled by default. Though it’s true that it’s not immediately obvious what face to customize. At the very least these faces appear in the customize group of typescript. We can add something to the docstring of the major mode, too. > >> > >>> > >>> These are the downsides of mode-specific faces, and if we think it's > >>> important enough to have them, we should resolve these issues when we > >>> install such faces. > > > > Then it is fine by me, as long as those measures you mentioned are > > taken to make sure users know how to customize font-lock with these > > faces. > > Cool. I pushed the change. Thanks, but please also tell in the doc string of the mode which font-lock level uses these special faces.