From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63251: 28.2; vhdl-mode contribution Date: Thu, 04 May 2023 08:16:47 +0300 Message-ID: <83mt2kllq8.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63251@debbugs.gnu.org To: Cyril Arnould , Reto Zimmermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 04 07:17:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puRLE-0006Bu-W2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 May 2023 07:17:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puRKy-0003Sx-2j; Thu, 04 May 2023 01:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRKw-0003So-Ur for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 01:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puRKw-0007MP-Jd for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 01:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puRKw-0003ix-1D for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 01:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 05:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63251 X-GNU-PR-Package: emacs Original-Received: via spool by 63251-submit@debbugs.gnu.org id=B63251.168317737014252 (code B ref 63251); Thu, 04 May 2023 05:17:01 +0000 Original-Received: (at 63251) by debbugs.gnu.org; 4 May 2023 05:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:48213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puRK5-0003hn-Qk for submit@debbugs.gnu.org; Thu, 04 May 2023 01:16:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puRK0-0003h0-GX for 63251@debbugs.gnu.org; Thu, 04 May 2023 01:16:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRJs-0007DP-SD; Thu, 04 May 2023 01:15:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cj0NHSQnRY39694sLQB3K7hujXz4ISd3BOevJ+VlDic=; b=bERtg9YzXz/x iyeoCL3YbvuPrs6EHdfQN5yGIe1hKb3xMyDtK0VCey8Oj2i1wieYKsXTfW35q14pnOWIjyGR7kSLj RJM3WvRrYbMZXgOtxhUwY9sKAC+9X+0YQPXVTdBmUGvIingbVm3XMU4RrFgT4ggDfH2gx25X8tQaO mCELXBkgqV4uTbVvCmRnzJbuSKJx7PYSXV5BBdBY+y/6JBWonUeXq7IjkMDC/HLa6mKidQ7+RRHeS Ft1wj7QnrWWW3VRqj9I1pPplIbiUmQy8LPHnm5TK11CDV+lI2Dna/wwv2p6fHfWE5T6wJOsYy6jXN qvTDQfMy/Oktr7uHUEMPuA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puRJs-0008SO-A7; Thu, 04 May 2023 01:15:56 -0400 In-Reply-To: (message from Cyril Arnould on Wed, 3 May 2023 19:40:18 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260995 Archived-At: > From: Cyril Arnould > Date: Wed, 3 May 2023 19:40:18 +0000 > > Following bug#62508, I've taken a bit of a closer look at the compiler > regexp for ModelSim. I've modified it so that it can differentiate > between Errors, Warnings and Notes when highlighting. I also make use of > Xilinx Vivado at work, for which I've added a new compiler entry: > > > --- a/lisp/progmodes/vhdl-mode.el > +++ b/lisp/progmodes/vhdl-mode.el > @@ -286,7 +286,7 @@ vhdl-compiler-alist > ;; counter_rtl.vhd(29):Conditional signal assignment line__29 > ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1" > nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim" > - ("^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil) > + ("^\\(?:\\(?1:ERROR\\|\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warning\\)\\|\\(?3:NOTE\\|\\*\\* Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(?4:[^ \t\n]+\\)(\\(?5:[0-9]+\\)):" 4 5 nil (2 . 3)) > ("" 0) > ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat" > "\\1/_primary.dat" "\\1/body.dat" downcase)) > @@ -385,6 +385,13 @@ vhdl-compiler-alist > nil "mkdir \\1" "./" "work/" "Makefile" "xilinx" > ("^ERROR:HDLParsers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\." 1 2 nil) ("" 0) > nil) > + ;; Xilinx Vivado: > + ;; ERROR: [VRFC 10-1412] syntax error near o_idle [test.vhd:23] > + ("Xilinx Vivado" "xvhdl" "" "make" "-f \\1" > + nil "mkdir \\1" "./" "work" "Makefile" "vivado" > + ("^\\(?:\\(?1:ERROR\\)\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\) \\[\\(?4:[^ \t\n]+\\):\\(?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0) > + ("\\1/entity" "\\2/\\1" "\\1/configuration" > + "\\1/package" "\\1/body" downcase)) > ) > "List of available VHDL compilers and their properties. > Each list entry specifies the following items for a compiler: > > > The patch was generated from the emacs master branch. I would greatly > appreciate it if these changes could find their way in some form into a > future emacs release. Reto, any comments on these changes? Thanks.