From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 17:55:26 +0300 Message-ID: <83mt1rjg69.fsf@gnu.org> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 16:56:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2Yrb-0008x5-JZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 16:56:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2YrL-0003YR-Mn; Fri, 26 May 2023 10:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2YrJ-0003YA-Sg for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 10:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2YrJ-00058H-KL for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 10:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2YrJ-0003uo-HB for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 10:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168511290614803 (code B ref 63731); Fri, 26 May 2023 14:56:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 14:55:06 +0000 Original-Received: from localhost ([127.0.0.1]:50538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2YqP-0003qh-RB for submit@debbugs.gnu.org; Fri, 26 May 2023 10:55:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2YqO-0003q5-30 for 63731@debbugs.gnu.org; Fri, 26 May 2023 10:55:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2YqI-0004lQ-LR; Fri, 26 May 2023 10:54:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rWf5UOccMJV0zEJZBg+20A04iSuMOFcVkTKV8XnCziQ=; b=XjP4RZs7yYI0 82WDVUOmgpwHswz7sym9YngiXvvPwUJYaYjYAad8uscVnEqY3DQlOSgIfAYjRXjWpUnukSnsrVNbP bU6hdcnV73k94z80PsShd/XUcSbQE5qfR4bcIh8BPESDI3sXh25/yrpyNWpOYgid0qfPoRmuOu8Zj QlVrao6llwfFpNpa9pRaVE/9CFn7/lkjGAqOzT2A5G5uIC+EsrCwc6VT+zbqssF3s3vyX8KYvO9xW R6X8XDLH1q3hbmkRBvQyAMJO/MVibpdMXL23Q5F+Nhze+mGPBw6TFfY1cEI4uHfgRFxi4bjx0Jioj cyyjf4PVF+HZDoI7FXkLcg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2YqE-00060p-Ja; Fri, 26 May 2023 10:54:57 -0400 In-Reply-To: <87edn3mbr3.fsf@gmail.com> (message from Robert Pluim on Fri, 26 May 2023 16:02:40 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262436 Archived-At: > From: Robert Pluim > Cc: steven@stebalien.com, 63731@debbugs.gnu.org > Date: Fri, 26 May 2023 16:02:40 +0200 > > Eli> What does this issue mean for the other VS-n characters, though? > Eli> Should we perhaps install something similar for them as well? > > For VS-15 maybe? The following gets me text-presentation composition > with CHAR+FE0E and emoji-presentation with CHAR+FE0F Actually, I forgot about compose-gstring-for-variation-glyph. My question was actually whether the general setting in (let ((elt `([,(purecopy "\\c.\\c^+") 1 compose-gstring-for-graphic] [nil 0 compose-gstring-for-graphic]))) (map-char-table #'(lambda (key val) (if (memq val '(Mn Mc Me)) (set-char-table-range composition-function-table key elt))) unicode-category-table)) affects also the VS-n selectors. But since the latter setting of (let ((elt '([".." 1 compose-gstring-for-variation-glyph]))) (set-char-table-range composition-function-table '(#xFE00 . #xFE0E) elt) (set-char-table-range composition-function-table '(#xE0100 . #xE01EF) elt)) takes care of all the VS-n selectors except VS-16, and your patch now will take care of VS-16, it sounds like we don't need to care about other VS-n selectors? Or are you saying that without including VS-15, CHAR+FE0E is not displayed using its text representation? Did you test the proposed change with the admin/emoji-*.txt files, to make sure they all still display OK?