From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 15:46:20 +0300 Message-ID: <83mt1f5rab.fsf@gnu.org> References: <83y1l7gzqw.fsf@gnu.org> <87ilcb2p1l.fsf@posteo.net> <87sfb8g85v.fsf@posteo.net> <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> <87h6rnoa8v.fsf@posteo.net> <83v8g35ybo.fsf@gnu.org> <87cz2bo3qu.fsf@posteo.net> <83pm6b5t1i.fsf@gnu.org> <878rczo28v.fsf@posteo.net> <83o7lv5sjc.fsf@gnu.org> <874jnno1bi.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23804"; mail-complaints-to="usenet@ciao.gmane.io" Cc: artscan@list.ru, 63757@debbugs.gnu.org, monnier@iro.umontreal.ca To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 14:46:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5n7h-00061S-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 14:46:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5n7V-0007Zf-52; Sun, 04 Jun 2023 08:46:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5n7S-0007ZG-R3 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5n7S-0004a0-A1 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5n7S-0008RS-5v for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168588274232409 (code B ref 63757); Sun, 04 Jun 2023 12:46:02 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 12:45:42 +0000 Original-Received: from localhost ([127.0.0.1]:45308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5n77-0008Qd-Ek for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:45:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5n72-0008QJ-Ak for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 08:45:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5n6t-0004Qr-DA; Sun, 04 Jun 2023 08:45:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Wifyfs3Xdwgtl6jGy5CS1BRg3TmMjdlDrj3wCQzSPUM=; b=oSLkYUFqEng4 n2Yd3FIDntfdu3uddFFGnw4DIL5t/XF26pHceOgIRdbT/YQe5B/jCIvG/jNKS8y0ECHGwgMbXLcM+ bmDszgtGsElaUAwNug/TFCmHP+Pt6b2u5J2Uz8cn/HZGF1GIv1dfJ6L2X2wJdTwGAnwCVM3NZ/2kA TDaMCTqVGJyQy3+S3pk3p0s+8YM2AZYQyY82toelcsv6cpcgigiuDhxwdxTzPOEJvHPR+34/PS/se FkTRKDttep23jPFzVbEgEGa98aGhL4POJxyQgnnXinddBOp46ntS75ZnPXwCqT0wd8bTPb6srw+gF mTKxuavGNcAvWv0KI+QzGA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5n6s-000885-TJ; Sun, 04 Jun 2023 08:45:27 -0400 In-Reply-To: <874jnno1bi.fsf@posteo.net> (message from Philip Kaludercic on Sun, 04 Jun 2023 12:32:17 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262947 Archived-At: > From: Philip Kaludercic > Cc: artscan@list.ru, monnier@iro.umontreal.ca, 63757@debbugs.gnu.org > Date: Sun, 04 Jun 2023 12:32:17 +0000 > > Eli Zaretskii writes: > > >> - (dolist (pkg-dir (directory-files dir t "\\`[^.]" t)) > >> + (dolist (pkg-dir (directory-files dir t "\\`[^.]")) > >> (when (file-directory-p pkg-dir) > >> (package-load-descriptor pkg-dir)))))) > >> > >> (I attached the *vc-diff* buffer, but before sending the message I > >> invoked vc-diff again which modified the buffer contents. Should have > >> just copied the diff manually...) > > > > Thanks, now it at least makes sense. > > > > But why does it matter whether the package directory names are sorted > > or not? Is sorting package versions the same as sorting the names of > > their directories? > > No, because directories are sorted by their names and by that metric, > "foo-10" is less than "foo-9". But since package archives like MELPA > use ISO 8601-like release-dates as version numbers, the order "works". > If we disable sorting, the files returned in any order the operating > system might have arbitrary stored the directory entries in which might > even change depending on the file system. So at the very least we can > argue that while sorting does not solve the issue, it provides a quick > hack to prevent sudden breakage from Emacs 28 to Emacs 29, due to users > relying on this kind of behaviour. A proper solution, that takes > version numbers into account should be prepared on the master branch. OK, thanks. Please install on emacs-29, and let's hope this doesn't cause new problems.