From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q Date: Sun, 09 Jul 2023 08:43:58 +0300 Message-ID: <83mt05bpwh.fsf@gnu.org> References: <87jzvmd17f.fsf@gmx.net> <83cz1etpdm.fsf@gnu.org> <2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com> <28fa0831-bb28-b7c1-1535-3a950f6b2545@gmail.com> <83y1jqdeqm.fsf@gnu.org> <748ccb81-d56c-76aa-d06b-47e4e3807ddb@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 09 07:44:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qINDT-0000Nl-EP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jul 2023 07:44:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qINDJ-0004e6-UR; Sun, 09 Jul 2023 01:44:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qINDH-0004dc-45 for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 01:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qINDG-0006Fh-FI for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 01:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qINDG-0005lL-B5 for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 01:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jul 2023 05:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64347 X-GNU-PR-Package: emacs Original-Received: via spool by 64347-submit@debbugs.gnu.org id=B64347.168888143822135 (code B ref 64347); Sun, 09 Jul 2023 05:44:02 +0000 Original-Received: (at 64347) by debbugs.gnu.org; 9 Jul 2023 05:43:58 +0000 Original-Received: from localhost ([127.0.0.1]:45580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qINDC-0005kx-IB for submit@debbugs.gnu.org; Sun, 09 Jul 2023 01:43:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qINDB-0005kk-Ig for 64347@debbugs.gnu.org; Sun, 09 Jul 2023 01:43:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIND6-0006B8-3X; Sun, 09 Jul 2023 01:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=N2Eim++PRMrjM0NY003Z+zyh+MfFPEvr+R7e7/ug904=; b=nEDMcn3wK7xtSmftjqhZ 50SOnjYB0egCO6Hhdzl54TGJEBXtolhVU+XOI13uc6RksFY+yPyX8DclwRlRgHqs7D4mXZUYI+Xm9 V0a6Szt5IHKfTZwb/BbQcOirBGuK711AOSaD70liJ36mO5yVmqYvGxrdCVSObLxMwY+myEzRghHQl JmwZd7kLTx22O0yLECFgjJdbgVMJ52m7w06bVDJKpXeFoBXlEnfhgDgKsrTg4a/hqKQhGtxABA6Yy VtM467qUOT9rCh4mPomg8i2X7kHvYV6xuLHDblCuwqY9+rKOpk0H+Kly/DteDYHMpNeI2TtLLEtEE MsYXHBQHlQ8vvQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIND4-0002Xl-Rk; Sun, 09 Jul 2023 01:43:51 -0400 In-Reply-To: <748ccb81-d56c-76aa-d06b-47e4e3807ddb@gmail.com> (message from Mauro Aranda on Sat, 8 Jul 2023 18:32:15 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264809 Archived-At: > Date: Sat, 8 Jul 2023 18:32:15 -0300 > Cc: 64347@debbugs.gnu.org, stephen.berman@gmx.net > From: Mauro Aranda > > Since there are both ways to specify the same information for the > :line-width value, there's always a chance of not sending the expected > format to face-spec-match-p. > > Let's say we have (:line-width 1).  Then the pre-filter converts it into > (:line-width (1 . 1)), and then the post-filter should convert it back > to (:line-width 1), and that works. > > But if we have (:line-width (1 . 1)), the pre-filter does nothing, and > the post-filter will transform it into (:line-width 1), and that way > specs won't match. > > So sometimes we want to post-filter to (:line-width WIDTH) and sometimes > to (VWIDTH . HWIDTH) and there's currently not enough information to do > that, or at least I missed it. > > > Did you make any progress with the one bug that's left after the other > > two are fixed? > > I did find that face-attr-match-p uses equal even with properties like > :underline and :box that can have plists as values.  But I haven't tried > to fix it, because I got frustrated with the post-filter thing. I guess I'm missing something here: why do we need those pre-filter and post-filter conversions? The C code understands both forms of :line-width, so there should be no need for Lisp to do any conversions, right? So why do we do that? why not simply leave the spec as it was originally?