From: Eli Zaretskii <eliz@gnu.org>
To: sbaugh@catern.com
Cc: philipk@posteo.net, 64543@debbugs.gnu.org
Subject: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval
Date: Thu, 13 Jul 2023 07:54:25 +0300 [thread overview]
Message-ID: <83mt005s3i.fsf@gnu.org> (raw)
In-Reply-To: <87ttu9j5ii.fsf@catern.com> (sbaugh@catern.com)
> Cc: 64543@debbugs.gnu.org
> From: sbaugh@catern.com
> Date: Wed, 12 Jul 2023 19:26:13 +0000 (UTC)
>
> +(defun uniquify-dirname-transform-default (dirname)
> + "Simply return DIRNAME unchanged."
> + dirname)
If you don't explain the need for its existence in the doc string,
this function looks weirdly redundant.
> +(defcustom uniquify-dirname-transform #'uniquify-dirname-transform-default
> + "A function to transform the dirname used to uniquify a buffer.
Come to think about it, why not use 'identity as the default value?
Then the above weird function could be deleted.
next prev parent reply other threads:[~2023-07-13 4:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 17:08 bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval sbaugh
2023-07-10 14:13 ` Philip Kaludercic
2023-07-12 19:26 ` sbaugh
2023-07-12 19:48 ` Philip Kaludercic
2023-07-12 19:56 ` Spencer Baugh
2023-07-14 19:44 ` Philip Kaludercic
2023-07-15 5:49 ` Eli Zaretskii
2023-07-15 7:40 ` Philip Kaludercic
2023-07-15 8:57 ` Eli Zaretskii
2023-07-13 4:54 ` Eli Zaretskii [this message]
[not found] <c6bc281e-d6e5-4c5c-8315-157c6b089330@email.android.com>
2023-07-15 9:23 ` Eli Zaretskii
2023-07-15 10:05 ` Philip Kaludercic
2023-07-15 10:23 ` Eli Zaretskii
2023-07-15 23:33 ` Philip Kaludercic
2023-07-15 17:45 ` sbaugh
2023-07-16 12:33 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt005s3i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64543@debbugs.gnu.org \
--cc=philipk@posteo.net \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).