From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: adam.porter@47ap.net, philipk@posteo.net, 65666@debbugs.gnu.org
Subject: bug#65666: Lockfiles break package-vc-install-from-checkout
Date: Sat, 02 Sep 2023 10:49:38 +0300 [thread overview]
Message-ID: <83msy59fql.fsf@gnu.org> (raw)
In-Reply-To: <87ledpmp8f.fsf@breatheoutbreathe.in> (message from Joseph Turner on Fri, 01 Sep 2023 16:43:27 -0700)
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Cc: Eli Zaretskii <eliz@gnu.org>, 65666@debbugs.gnu.org, adam.porter@47ap.net
> Date: Fri, 01 Sep 2023 16:43:27 -0700
>
>
> Philip Kaludercic <philipk@posteo.net> writes:
>
> > LGTM, but I wonder if there is a better way to detect lockfiles
> > specifically? If not, I can imagine that just using `file-exists-p'
> > would a too broad check, in the sense that it could make it difficult to
> > find other issues?
>
> We could use a regex like
>
> (unless (string-match-p (rx string-start ".#") file))
Or make the REGEXP argument to directory-files-recursively more
specific, to reject lock files.
But yes, the use of file-exists-p is not TRT, IMO.
next prev parent reply other threads:[~2023-09-02 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 21:47 bug#65666: Lockfiles break package-vc-install-from-checkout Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 5:50 ` Eli Zaretskii
2023-09-01 6:18 ` joseph--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 12:52 ` Philip Kaludercic
2023-09-01 23:43 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 7:49 ` Eli Zaretskii [this message]
2023-09-02 17:15 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 17:21 ` Eli Zaretskii
2023-09-03 7:03 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83msy59fql.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65666@debbugs.gnu.org \
--cc=adam.porter@47ap.net \
--cc=joseph@breatheoutbreathe.in \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).