From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 68006@debbugs.gnu.org
Subject: bug#68006: 30.0.50; Image-mode speed
Date: Fri, 29 Dec 2023 14:13:03 +0200 [thread overview]
Message-ID: <83mstt5hrk.fsf@gnu.org> (raw)
In-Reply-To: <87wmsxmff3.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 29 Dec 2023 12:11:44 +0100)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 68006@debbugs.gnu.org
> Date: Fri, 29 Dec 2023 12:11:44 +0100
>
> What about this new patch? It works for me as intended but might need
> better names and better docs. Thanks.
>
> +(defcustom image-mode-eager-cache-flush t
> + "Non-nil means flush image from cache eagerly.
> +When set to nil, be aware that the image cache could grow fast
> +but an image previously displayed will show faster."
This doc string should explain the effects better, in terms of
user-facing behavior, not in terms of technical aspects of the code.
> - ;; Discard any stale image data before looking it up again.
> - (image-flush image)
> + (if image-mode-eager-cache-flush
> + ;; Discard any stale image data before looking it up again.
> + (image-flush image)
> + ;; Add a content based hash into image spec to be sure that the
> + ;; cache is updated should the on disk image change.
> + (when (and filename (file-exists-p filename))
> + (setq image (append image (list :hash (image-contents-sha1 filename))))))
> +
I'm probably missing something: how would this assure that if the
image file is replaced, we re-read it from disk?
> +(defun image-contents-sha1 (filename)
> + "Compute the SHA-1 of the first 4KiB of FILENAME's contents. The
> +first 4KiB does not represent the whole file but was chosen
> +because it is fast enough for interactive usage."
The first line of a doc string should be a single complete sentence.
Thanks.
next prev parent reply other threads:[~2023-12-29 12:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 16:44 bug#68006: 30.0.50; Image-mode speed Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-24 17:01 ` Eli Zaretskii
2023-12-25 10:34 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 13:36 ` Eli Zaretskii
2023-12-25 18:59 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 19:30 ` Eli Zaretskii
2023-12-26 14:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-26 17:15 ` Eli Zaretskii
2023-12-26 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-26 18:43 ` Eli Zaretskii
2023-12-27 12:13 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-27 13:36 ` Eli Zaretskii
2023-12-29 11:11 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-29 12:13 ` Eli Zaretskii [this message]
2023-12-30 11:36 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-30 12:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-30 23:57 ` Stefan Kangas
2023-12-31 7:16 ` Eli Zaretskii
2024-01-02 0:19 ` Stefan Kangas
2024-01-02 12:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 12:49 ` Eli Zaretskii
2024-01-02 16:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-02 17:02 ` Eli Zaretskii
2024-01-04 16:47 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-04 17:43 ` Eli Zaretskii
2024-01-04 18:42 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-04 18:55 ` Eli Zaretskii
2024-01-04 19:16 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-04 19:54 ` Eli Zaretskii
2024-01-05 10:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 11:25 ` Eli Zaretskii
2024-01-05 13:26 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 13:40 ` Eli Zaretskii
2024-01-05 14:35 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 14:41 ` Eli Zaretskii
2024-01-05 14:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 13:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-01 10:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mstt5hrk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68006@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).