From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals) Date: Fri, 18 Feb 2011 16:51:13 +0200 Message-ID: <83lj1dv1jy.fsf@gnu.org> References: <87wrl423dm.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1298041616 24852 80.91.229.12 (18 Feb 2011 15:06:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Feb 2011 15:06:56 +0000 (UTC) Cc: cyd@stupidchicken.com, 7840@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 18 16:06:48 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PqRuy-0008Av-4F for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Feb 2011 16:06:48 +0100 Original-Received: from localhost ([127.0.0.1]:46620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqRux-0006U3-CA for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Feb 2011 10:06:47 -0500 Original-Received: from [140.186.70.92] (port=44037 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqRuq-0006Tm-Ia for bug-gnu-emacs@gnu.org; Fri, 18 Feb 2011 10:06:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PqRup-000086-BP for bug-gnu-emacs@gnu.org; Fri, 18 Feb 2011 10:06:40 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PqRup-00007x-A2 for bug-gnu-emacs@gnu.org; Fri, 18 Feb 2011 10:06:39 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PqRgg-0005qM-8z; Fri, 18 Feb 2011 09:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Feb 2011 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7840-submit@debbugs.gnu.org id=B7840.129804069322411 (code B ref 7840); Fri, 18 Feb 2011 14:52:02 +0000 Original-Received: (at 7840) by debbugs.gnu.org; 18 Feb 2011 14:51:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PqRgD-0005pQ-7Z for submit@debbugs.gnu.org; Fri, 18 Feb 2011 09:51:33 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PqRgB-0005pD-3C for 7840@debbugs.gnu.org; Fri, 18 Feb 2011 09:51:32 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LGT00300H0DDI00@a-mtaout20.012.net.il> for 7840@debbugs.gnu.org; Fri, 18 Feb 2011 16:51:09 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.140.24]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LGT00360IL5AIB0@a-mtaout20.012.net.il>; Fri, 18 Feb 2011 16:51:07 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 18 Feb 2011 09:52:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44235 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 7840@debbugs.gnu.org > Date: Mon, 14 Feb 2011 13:05:44 -0500 > > >> * terminal.c (create_terminal): Use default-keyboard-coding-system > >> and default-terminal-coding-system to initialize coding systems of > >> the new terminal. (Bug#7840) > >> > >> ! keyboard_coding = SYMBOL_VALUE (intern ("default-keyboard-coding-system")); > >> ! if (NILP (keyboard_coding) > >> ! || EQ (keyboard_coding, Qunbound) > >> ! || NILP (Fcoding_system_p (keyboard_coding))) > >> ! keyboard_coding = Qno_conversion; > >> ! terminal_coding = SYMBOL_VALUE (intern ("default-terminal-coding-system")); > > > This change doesn't build on the trunk, due to Stefan's 2010-04-20 > > change removing SYMBOL_VALUE. > > > I left out this change when doing the last merge from the branch. Would > > you mind working up a separate patch and applying it to the trunk? > > (Fsymbol_value apparently doesn't work here, because the symbols can be > > unbound and we don't want to signal an error.) > > We can just use Fboundp tests, when needed. I used find_symbol_value instead, which seems to be the Emacs 24 equivalent of SYMBOL_VALUE in this situation. Committed to the trunk.