From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10398: [PATCH] Use real vfork under Cygwin: it's fine these days Date: Wed, 11 Apr 2012 09:58:16 +0300 Message-ID: <83lim269h3.fsf@gnu.org> References: <31890c3c686da18017fafebac19a6529ee09950d.1325166842.git.dancol@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1334127674 4146 80.91.229.3 (11 Apr 2012 07:01:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 Apr 2012 07:01:14 +0000 (UTC) Cc: 10398@debbugs.gnu.org To: Lars Magne Ingebrigtsen , Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 11 09:01:11 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SHrYD-0006Zq-HO for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2012 09:01:09 +0200 Original-Received: from localhost ([::1]:46387 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHrYC-0000kR-Lv for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2012 03:01:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHrY6-0000jq-53 for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 03:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SHrY1-0002qz-Cc for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 03:01:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHrY1-0002qp-90 for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 03:00:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SHrZ4-0003lu-0q for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 03:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Apr 2012 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10398-submit@debbugs.gnu.org id=B10398.133412769014453 (code B ref 10398); Wed, 11 Apr 2012 07:02:01 +0000 Original-Received: (at 10398) by debbugs.gnu.org; 11 Apr 2012 07:01:30 +0000 Original-Received: from localhost ([127.0.0.1]:50243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHrYW-0003l2-Em for submit@debbugs.gnu.org; Wed, 11 Apr 2012 03:01:30 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:41898) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHrYQ-0003kl-V3 for 10398@debbugs.gnu.org; Wed, 11 Apr 2012 03:01:26 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M2A00200ZBXL600@a-mtaout22.012.net.il> for 10398@debbugs.gnu.org; Wed, 11 Apr 2012 10:00:06 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.57.204]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M2A0018VZG5VXB2@a-mtaout22.012.net.il>; Wed, 11 Apr 2012 10:00:06 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58756 Archived-At: > From: Lars Magne Ingebrigtsen > Cc: 10398@debbugs.gnu.org, Eli Zaretskii > Date: Wed, 11 Apr 2012 01:26:56 +0200 > > Daniel Colascione writes: > > > In Cygwin 1.7, vfork is an alias for fork. The vfork the #define in > > cygwin.h was protecting against is gone. It's better to use vfork now > > so that when Cygwin gains a new, working vfork, we use it > > automatically. > > [...] > > > -/* vfork() interacts badly with setsid(), causing ptys to fail to > > - change their controlling terminal */ > > -#define vfork fork > > Sounds sensible to me, but I'm no exactly (ahem) a Cygwin expert. > > Eli, what do you think? Not that _I_ am a Cygwin expert, but isn't it safer to do that only for Cygwin 1.7 and later? Ken, WDYT?