From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12471: Avoid some signal-handling races, and simplify. Date: Sat, 22 Sep 2012 14:16:12 +0300 Message-ID: <83lig2l343.fsf@gnu.org> References: <50590626.2070407@cs.ucla.edu> <83lig6yoim.fsf@gnu.org> <505AB299.9090605@cs.ucla.edu> <837grozizw.fsf@gnu.org> <505C1A75.9030509@cs.ucla.edu> <83mx0jydya.fsf@gnu.org> <505CA363.1000603@cs.ucla.edu> <836277xolr.fsf@gnu.org> <505CAE5B.8060802@cs.ucla.edu> <83zk4jw7sf.fsf@gnu.org> <505CC70B.6050308@cs.ucla.edu> <83obkywkmt.fsf@gnu.org> <505D7B33.4000504@cs.ucla.edu> <83haqqwhhv.fsf@gnu.org> <505D8799.8030905@cs.ucla.edu> <83mx0il69z.fsf@gnu.org> <505D9911.2020704@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1348312651 10368 80.91.229.3 (22 Sep 2012 11:17:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2012 11:17:31 +0000 (UTC) Cc: 12471@debbugs.gnu.org, lekktu@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 22 13:17:34 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TFNiI-0007cZ-4j for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Sep 2012 13:17:34 +0200 Original-Received: from localhost ([::1]:55060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFNiD-0007yX-Hq for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Sep 2012 07:17:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFNi8-0007vb-47 for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 07:17:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFNi4-0003lb-BD for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 07:17:24 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFNi4-0003lQ-7Y for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 07:17:20 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TFNjh-0008VB-Mt for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 07:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Sep 2012 11:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12471-submit@debbugs.gnu.org id=B12471.134831269832632 (code B ref 12471); Sat, 22 Sep 2012 11:19:01 +0000 Original-Received: (at 12471) by debbugs.gnu.org; 22 Sep 2012 11:18:18 +0000 Original-Received: from localhost ([127.0.0.1]:48159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TFNiv-0008Tl-Su for submit@debbugs.gnu.org; Sat, 22 Sep 2012 07:18:17 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:39008) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TFNip-0008TZ-No for 12471@debbugs.gnu.org; Sat, 22 Sep 2012 07:18:12 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MAR00J000ITKC00@a-mtaout20.012.net.il> for 12471@debbugs.gnu.org; Sat, 22 Sep 2012 14:16:23 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAR00J3P0NBK610@a-mtaout20.012.net.il>; Sat, 22 Sep 2012 14:16:23 +0300 (IDT) In-reply-to: <505D9911.2020704@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64732 Archived-At: > Date: Sat, 22 Sep 2012 03:55:13 -0700 > From: Paul Eggert > CC: 12471@debbugs.gnu.org, lekktu@gmail.com > > On 09/22/2012 03:07 AM, Eli Zaretskii wrote: > > > 'sys_kill' does not do what's expected from 'raise', far from it. > > It may not do what's expected for 'raise' for arbitrary Windows > applications, yes. But it doesn't need to do that. All that's > needed is what Emacs expects for 'raise'. 'sys_kill' doesn't support what Emacs expects from 'raise', except for SIGABRT. Please read the code, it's quite self-explanatory. > > for existing library functions, the only sane way to replace them > > is to have the replacement support all the features supported by the > > function being replaced. > > But the proposed patch does not replace the existing 'raise'. It does, as far as Emacs code is concerned. > > even if we want to support "only" the features you had in mind, > > 'sys_kill' will need to be extended to support all the fatal signals > > The current trunk is already invoking sys_kill with all those signals. > If this behavior isn't correct for Windows, it needs to be fixed, > regardless of whether the proposed patch is applied. The proposed > patch doesn't make this problem any worse, or any better. Yes, it does, in that it enters 'raise' into this messy picture.