From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9521: [RESEND] PATCH for bug #9521, *not* bug #9766 Date: Sat, 29 Dec 2012 10:53:00 +0200 Message-ID: <83lichkzo3.fsf@gnu.org> References: <87r4m999s2.fsf@foil.strangled.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1356771192 14538 80.91.229.3 (29 Dec 2012 08:53:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Dec 2012 08:53:12 +0000 (UTC) Cc: 9521-done@debbugs.gnu.org, 9766@debbugs.gnu.org To: mdl@alum.mit.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 29 09:53:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TosAY-0007tn-7h for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Dec 2012 09:53:26 +0100 Original-Received: from localhost ([::1]:34225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TosAJ-0000WR-JI for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Dec 2012 03:53:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TosAG-0000VD-AF for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 03:53:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TosAD-0006T7-Gy for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 03:53:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TosAD-0006Sx-E7 for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 03:53:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TosB8-0005ro-Ia for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 03:54:02 -0500 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Dec 2012 08:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 9521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 9521@debbugs.gnu.org, eliz@gnu.org, handa@m17n.org Original-Received: via spool by 9521-done@debbugs.gnu.org id=D9521.135677123522526 (code D ref 9521); Sat, 29 Dec 2012 08:54:02 +0000 Original-Received: (at 9521-done) by debbugs.gnu.org; 29 Dec 2012 08:53:55 +0000 Original-Received: from localhost ([127.0.0.1]:35581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TosB0-0005rG-MG for submit@debbugs.gnu.org; Sat, 29 Dec 2012 03:53:55 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:63581) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TosAy-0005qz-2f; Sat, 29 Dec 2012 03:53:53 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MFS00J00B8PDV00@a-mtaout20.012.net.il>; Sat, 29 Dec 2012 10:52:53 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MFS00JDGBC37U40@a-mtaout20.012.net.il>; Sat, 29 Dec 2012 10:52:52 +0200 (IST) In-reply-to: <87r4m999s2.fsf@foil.strangled.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69145 Archived-At: > From: Mark Lillibridge > Date: Fri, 28 Dec 2012 12:55:25 -0800 > > > This bug (#9521) was easy to fix. The problem was with the > rmail-insert-mime-forwarded-message function in rmailmm.el:1355: > > (defun rmail-insert-mime-forwarded-message (forward-buffer) > "Insert the message in FORWARD-BUFFER as a forwarded message. > This is the usual value of `rmail-insert-mime-forwarded-message-function'." > (let ((message-buffer > (with-current-buffer forward-buffer > (if rmail-buffer-swapped > forward-buffer > rmail-view-buffer)))) > (save-restriction > (narrow-to-region (point) (point)) > (message-forward-make-body-mime message-buffer)))) > > > This does exactly the wrong thing by inserting the decoded version > of the message. Swapping the two buffers (forward-buffer, > rmail-view-buffer) in the if expression fixes this: > > (defun rmail-insert-mime-forwarded-message (forward-buffer) > "Insert the message in FORWARD-BUFFER as a forwarded message. > This is the usual value of `rmail-insert-mime-forwarded-message-function'." > (let ((message-buffer > (with-current-buffer forward-buffer > (if rmail-buffer-swapped > > rmail-view-buffer > > forward-buffer)))) > (save-restriction > (narrow-to-region (point) (point)) > (message-forward-make-body-mime message-buffer)))) Thanks, I installed this simple change on the emacs-24 branch. > Note that this does not fix bug #9766, which was incorrectly merged > with bug #9521. The problem there (#9766) is that many email clients > including in particular, the iPad email app, do not properly display > RFC822 attachments or do not show it inline. Fixing that problem > requires substantial work, including on the design front. I think #9766 is about both problems. But I unmerged it anyway, and am leaving it open for now.