From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13949: 24.4.1; `fill-paragraph' should not always put the buffer as modified Date: Sun, 27 Mar 2016 17:56:26 +0300 Message-ID: <83lh54ynol.fsf@gnu.org> References: <56F12360.5030301@ro.ru> <83y49a4hga.fsf@gnu.org> <56F1837D.4060300@ro.ru> <83io0e4b5r.fsf@gnu.org> <56F19203.5040501@ro.ru> <87a8lkd2bc.fsf@wanadoo.es> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1459090643 26951 80.91.229.3 (27 Mar 2016 14:57:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 14:57:23 +0000 (UTC) Cc: jwiegley@gmail.com, j_k_v@ro.ru, 13949@debbugs.gnu.org To: =?UTF-8?Q?=C3=93scar?= Fuentes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 27 16:57:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akC7o-0001o5-Jf for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2016 16:57:08 +0200 Original-Received: from localhost ([::1]:36171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akC7n-0006ED-0h for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2016 10:57:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akC7j-0006E5-49 for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 10:57:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akC7i-0001U1-BN for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 10:57:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akC7i-0001Tw-8A for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 10:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akC7i-0003AE-0N for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Mar 2016 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13949-submit@debbugs.gnu.org id=B13949.145909062112156 (code B ref 13949); Sun, 27 Mar 2016 14:57:01 +0000 Original-Received: (at 13949) by debbugs.gnu.org; 27 Mar 2016 14:57:01 +0000 Original-Received: from localhost ([127.0.0.1]:40123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akC7g-00039z-VJ for submit@debbugs.gnu.org; Sun, 27 Mar 2016 10:57:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akC7e-00039k-4J for 13949@debbugs.gnu.org; Sun, 27 Mar 2016 10:56:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akC7V-0001TJ-H2 for 13949@debbugs.gnu.org; Sun, 27 Mar 2016 10:56:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akC7V-0001TF-E7; Sun, 27 Mar 2016 10:56:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3304 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1akC7U-0002C4-Kv; Sun, 27 Mar 2016 10:56:49 -0400 In-reply-to: <87a8lkd2bc.fsf@wanadoo.es> (message from =?UTF-8?Q?=C3=93scar?= Fuentes on Sun, 27 Mar 2016 05:31:19 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115553 Archived-At: > From: Óscar Fuentes > Date: Sun, 27 Mar 2016 05:31:19 +0200 > Cc: Jaakov , 13949@debbugs.gnu.org > > diff --git a/lisp/textmodes/fill.el b/lisp/textmodes/fill.el > index 100e2a2..9e1f430 100644 > --- a/lisp/textmodes/fill.el > +++ b/lisp/textmodes/fill.el > @@ -804,6 +804,7 @@ fill-paragraph > (interactive (progn > (barf-if-buffer-read-only) > (list (if current-prefix-arg 'full) t))) > + (setq h (if (buffer-modified-p) "" (secure-hash 'md5 (current-buffer)))) > (or > ;; 1. Fill the region if it is active when called interactively. > (and region transient-mark-mode mark-active > @@ -862,7 +863,10 @@ fill-paragraph > ;; fill-region. > (fill-region beg end justify) > (fill-region-as-paragraph beg end justify)))))) > - fill-pfx))) > + fill-pfx)) > + (when (and (not (string= h "")) > + (string= h (secure-hash 'md5 (current-buffer)))) > + (set-buffer-modified-p nil))) Thanks, but I'm not sure computing the hash is enough: the functions involved in refilling can change text properties, so the test should also account for that.