From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23571: 25.1.50; Click-mouse-1 = Drag-mouse-1 in Gnus Article buffer Date: Tue, 07 Jun 2016 18:03:53 +0300 Message-ID: <83lh2hrqg6.fsf@gnu.org> References: <87futfbio4.fsf@gmx.net> <874m9k3inf.fsf@gmx.net> <83zirc22sf.fsf@gnu.org> <87r3caw1k5.fsf@gmx.net> <83twh5spa1.fsf@gnu.org> <8760tlqsh2.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1465311869 11111 80.91.229.3 (7 Jun 2016 15:04:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jun 2016 15:04:29 +0000 (UTC) Cc: 23571@debbugs.gnu.org To: Stephen Berman , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 07 17:04:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bAIYA-0005ko-Mh for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2016 17:04:14 +0200 Original-Received: from localhost ([::1]:50800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIYA-0007Gl-5g for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2016 11:04:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIY2-0007Cz-EP for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 11:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAIXy-0001Og-Dc for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 11:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIXy-0001OV-AO for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 11:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bAIXy-0000qZ-1H for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2016 11:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2016 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23571 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23571-submit@debbugs.gnu.org id=B23571.14653118153221 (code B ref 23571); Tue, 07 Jun 2016 15:04:01 +0000 Original-Received: (at 23571) by debbugs.gnu.org; 7 Jun 2016 15:03:35 +0000 Original-Received: from localhost ([127.0.0.1]:58874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAIXX-0000pt-Iq for submit@debbugs.gnu.org; Tue, 07 Jun 2016 11:03:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAIXW-0000ph-0d for 23571@debbugs.gnu.org; Tue, 07 Jun 2016 11:03:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAIXN-0001E7-0e for 23571@debbugs.gnu.org; Tue, 07 Jun 2016 11:03:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIXM-0001Dm-TP; Tue, 07 Jun 2016 11:03:24 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4646 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bAIXK-0000MS-NB; Tue, 07 Jun 2016 11:03:23 -0400 In-reply-to: <8760tlqsh2.fsf@gmx.net> (message from Stephen Berman on Tue, 07 Jun 2016 11:05:29 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119209 Archived-At: > From: Stephen Berman > Cc: 23571@debbugs.gnu.org > Date: Tue, 07 Jun 2016 11:05:29 +0200 > > On Tue, 07 Jun 2016 05:31:34 +0300 Eli Zaretskii wrote: > > >> From: Stephen Berman > >> Cc: 23571@debbugs.gnu.org > >> Date: Mon, 06 Jun 2016 21:38:02 +0200 > >> > >> >> 72166f2f3dba18f1217c666574032f5a0351ed65 is the first bad commit > >> >> commit 72166f2f3dba18f1217c666574032f5a0351ed65 > >> >> Author: Martin Rudalics > >> >> Date: Tue May 3 08:38:49 2016 +0200 > >> >> > >> >> Bind `widget-button-click' to mouse-1/-2 instead of down-mouse-1/-2 > >> >> > >> >> * lisp/wid-edit.el (widget-keymap): Bind `widget-button-click' > >> >> to mouse-1/-2 instead of down-mouse-1/-2. Suggested by Stefan > >> >> Monnier. (Bug#19185, Bug#20398) > >> > > >> > So I guess Gnus needs to do something to countermand the low-level > >> > change, right? > >> > >> It turns out it's not just Gnus Article buffers (as presciently > >> suggested by the title of bug#23653, which I merged with this one): in > >> fact, the same problem appears to happen in all packages in which > >> buffers use widget-keymap; there are quite a few of these, as rgrepping > >> for widget-keymap on the lisp directory shows, and in all that I tried > >> (cus-edit, wid-browse, recentf, printing, secrets, image-dired, > >> todo-mode) the problem with mouse-1 occurred. So I think the fix should > >> be in widget-button-click, or somewhere at that level, and not in all of > >> its users. > > > > How do you do that without reintroducing the bug referenced in the > > above commit's log message? > > I went through those two bug reports and I cannot reproduce the > problematic cases (bug#19185: mouse-2 running mouse-yank-primary in a > Gnus Article buffer; bug#20398: mouse-1 raising error "No selection is > available" on links in a Customize buffer) with -Q in current emacs-25, > which does not include the above commit. And when I revert that commit > in master I also cannot reproduce those problems. So it's not clear to > me what that commit is trying to fix. I hope Martin will be able to help us answer that question.