From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23574: 24.5; Overzealous underlining in emacs-nox Date: Wed, 08 Jun 2016 20:05:34 +0300 Message-ID: <83lh2fr4pt.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1465405586 16110 80.91.229.3 (8 Jun 2016 17:06:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jun 2016 17:06:26 +0000 (UTC) Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 08 19:06:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bAgvl-00059l-Cn for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jun 2016 19:06:13 +0200 Original-Received: from localhost ([::1]:58527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAgvk-0003JO-Oe for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jun 2016 13:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAgve-0003JG-Bs for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 13:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAgva-0005Jf-0l for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 13:06:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAgvZ-0005Jb-TG for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 13:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bAgvZ-0007ow-Oa for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 13:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2016 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 23574-submit@debbugs.gnu.org id=B23574.146540551830001 (code B ref 23574); Wed, 08 Jun 2016 17:06:01 +0000 Original-Received: (at 23574) by debbugs.gnu.org; 8 Jun 2016 17:05:18 +0000 Original-Received: from localhost ([127.0.0.1]:33056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAgus-0007np-8n for submit@debbugs.gnu.org; Wed, 08 Jun 2016 13:05:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAguq-0007nd-FW for 23574@debbugs.gnu.org; Wed, 08 Jun 2016 13:05:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAguh-00051K-80 for 23574@debbugs.gnu.org; Wed, 08 Jun 2016 13:05:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAguX-0004z4-Oj; Wed, 08 Jun 2016 13:04:57 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bAguV-0004gX-P4; Wed, 08 Jun 2016 13:04:56 -0400 In-reply-to: <5757BC3A.5070402@gmx.at> (message from martin rudalics on Wed, 08 Jun 2016 08:33:30 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119287 Archived-At: > Date: Wed, 08 Jun 2016 08:33:30 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > This has the advantage of a much better doc-string. The only details > missing are whether the last character of a line is the newline > character, whether a non-printable character's attributes count, how > invisible characters are treated and whether the :display attribute has > any impact. Since I have no good idea about all of these I deliberately > did not try to cover them. I do know about these, but I don't thunk we should document all those details, since there are too many possible variations, and it's too easy to be inaccurate. "the last face used on the line" is good enough, I think. > I'm not sure whether your proposal (it obviously was my first idea as > well) is less expensive, though. If the value of our variable is a > list, the display engine has to go through the properties of the last > character and compare them against the members of this list. Or go > through all members of the list and compare them against the character's > properties - neither of these approaches is cheap even if optimizations > are applied. No, it need not do any of that. The list is fixed for each redisplay cycle of each buffer, so the list can be processed only once into a bitmap of flags that tell which face attributes trigger face extension. Then all redisplay needs to do is compare the attributes of the face loaded into the iterator object at end of each line with these flags. > And then I thought about the - possibly silly idea - that a user might > want to put a property like :background on all lines displayed, > regardless of the last character's attributes. Such a user would have > to, before displaying the relevant buffer parts, go through all these > lines and add that property to the newline (?) character of each line. > Now I bet that the greater part of such users would put the property on > all newline characters of the buffer instead of using something like > ‘pre-redisplay-functions’ where even I couldn't tell whether it gets the > window's start and end positions always right. Hmm.. not sure how this is related.