bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[ja.nguyen]

Line number is displayed in fringe and gets cut off when scrolling.



In GNU Emacs 25.0.95.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1603))
 of 2016-06-10 built on builder10-9.local
Windowing system distributor 'Apple', version 10.3.1404
Configured using:
 'configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp''

Configured features:
NOTIFY ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  focus-autosave-mode: t
  diff-auto-refine-mode: t
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  shell-dirtrack-mode: t
  persp-mode: t
  which-key-mode: t
  evil-smartparens-mode: t
  elisp-slime-nav-mode: t
  company-statistics-mode: t
  company-quickhelp-mode: t
  eval-sexp-fu-flash-mode: t
  rainbow-delimiters-mode: t
  flycheck-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-company-mode: t
  company-mode: t
  global-evil-surround-mode: t
  evil-surround-mode: t
  global-evil-visualstar-mode: t
  evil-visualstar-mode: t
  global-evil-matchit-mode: t
  evil-matchit-mode: t
  leader-map-override-mode: t
  global-leader-map-override-mode: t
  evil-mode: t
  evil-local-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  recentf-mode: t
  flx-ido-mode: t
  ido-everywhere: t
  smartparens-global-mode: t
  smartparens-strict-mode: t
  smartparens-mode: t
  show-paren-mode: t
  global-auto-revert-mode: t
  auto-revert-mode: t
  fold-dwim-org/minor-mode: t
  m-leader-map-override-mode: t
  global-m-leader-map-override-mode: t
  winner-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  hs-minor-mode: t

Recent messages:
Configuring package focus-autosave-mode...done
Quit [2 times]
Configuring package smex...done
Quit
Mark saved where search started [2 times]
Saving file /Users/james/.emacs.d/init.el...
Wrote /Users/james/.emacs.d/init.el
Quit [2 times]
Indenting region...done
Indented buffer.

Load-path shadows:
~/.emacs.d/fork/company-mode/company hides /Users/james/.emacs.d/elpa/company-20160522.1835/company
~/.emacs.d/fork/company-mode/company-yasnippet hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-yasnippet
~/.emacs.d/fork/company-mode/company-xcode hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-xcode
~/.emacs.d/fork/company-mode/company-tempo hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-tempo
~/.emacs.d/fork/company-mode/company-template hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-template
~/.emacs.d/fork/company-mode/company-semantic hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-semantic
~/.emacs.d/fork/company-mode/company-oddmuse hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-oddmuse
~/.emacs.d/fork/company-mode/company-nxml hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-nxml
~/.emacs.d/fork/company-mode/company-keywords hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-keywords
~/.emacs.d/fork/company-mode/company-ispell hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-ispell
~/.emacs.d/fork/company-mode/company-gtags hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-gtags
~/.emacs.d/fork/company-mode/company-files hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-files
~/.emacs.d/fork/company-mode/company-etags hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-etags
~/.emacs.d/fork/company-mode/company-elisp hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-elisp
~/.emacs.d/fork/company-mode/company-eclim hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-eclim
~/.emacs.d/fork/company-mode/company-dabbrev hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-dabbrev
~/.emacs.d/fork/company-mode/company-dabbrev-code hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-dabbrev-code
~/.emacs.d/fork/company-mode/company-css hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-css
~/.emacs.d/fork/company-mode/company-cmake hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-cmake
~/.emacs.d/fork/company-mode/company-clang hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-clang
~/.emacs.d/fork/company-mode/company-capf hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-capf
~/.emacs.d/fork/company-mode/company-bbdb hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-bbdb
~/.emacs.d/fork/company-mode/company-abbrev hides /Users/james/.emacs.d/elpa/company-20160522.1835/company-abbrev
/Users/james/.emacs.d/elpa/seq-2.15/seq hides /Applications/Emacs 3.app/Contents/Resources/lisp/emacs-lisp/seq
/Applications/Emacs 3.app/Contents/Resources/lisp/emacs-lisp/let-alist hides /Users/james/.emacs.d/elpa/let-alist-1.0.4/let-alist
/Users/james/.emacs.d/elpa/flycheck-20160606.302/flycheck hides /Users/james/.emacs.d/fork/flycheck/flycheck
/Users/james/.emacs.d/elpa/flycheck-20160606.302/flycheck-ert hides /Users/james/.emacs.d/fork/flycheck/flycheck-ert
/Users/james/.emacs.d/elpa/flycheck-20160606.302/flycheck-buttercup hides /Users/james/.emacs.d/fork/flycheck/flycheck-buttercup
/Users/james/.emacs.d/elpa/motion-mode-20140919.1856/motion-mode hides /Users/james/.emacs.d/fork/motion-mode/motion-mode
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens hides /Users/james/.emacs.d/fork/smartparens/smartparens
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-scala hides /Users/james/.emacs.d/fork/smartparens/smartparens-scala
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-rust hides /Users/james/.emacs.d/fork/smartparens/smartparens-rust
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-ruby hides /Users/james/.emacs.d/fork/smartparens/smartparens-ruby
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-racket hides /Users/james/.emacs.d/fork/smartparens/smartparens-racket
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-python hides /Users/james/.emacs.d/fork/smartparens/smartparens-python
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-pkg hides /Users/james/.emacs.d/fork/smartparens/smartparens-pkg
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-lua hides /Users/james/.emacs.d/fork/smartparens/smartparens-lua
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-latex hides /Users/james/.emacs.d/fork/smartparens/smartparens-latex
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-html hides /Users/james/.emacs.d/fork/smartparens/smartparens-html
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-haskell hides /Users/james/.emacs.d/fork/smartparens/smartparens-haskell
/Users/james/.emacs.d/elpa/smartparens-20160521.508/smartparens-config hides /Users/james/.emacs.d/fork/smartparens/smartparens-config
/Applications/Emacs 3.app/Contents/Resources/lisp/env hides /Users/james/.emacs.d/fork/smartparens/features/support/env
/Applications/Emacs 3.app/Contents/Resources/lisp/env hides /Users/james/.emacs.d/fork/xcode-mode/features/support/env
/Applications/Emacs 3.app/Contents/Resources/lisp/emacs-lisp/warnings hides /Users/james/.emacs.d/fork/flycheck/test/resources/language/emacs-lisp/warnings

Features:
(shadow sort mail-extr emacsbug sendmail tabify smex misearch
multi-isearch focus-autosave-mode vc-git colir color evil-magit
magit-blame magit-stash magit-bisect magit-remote magit-commit
magit-sequence magit magit-apply magit-wip magit-log magit-diff
smerge-mode diff-mode magit-core magit-autorevert magit-process
magit-popup magit-mode magit-git crm magit-section magit-utils
git-commit log-edit message rfc822 mml mml-sec epg mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev
mail-utils gmm-utils mailheader pcvs-util add-log with-editor
async-bytecomp async tramp-sh tramp tramp-compat tramp-loaddefs trampver
shell pcomplete format-spec server perspective which-key
evil-smartparens elisp-slime-nav cider-eval-sexp-fu eval-sexp-fu
company-statistics company-quickhelp pos-tip parent-mode warnings
highlight rainbow-delimiters flycheck json map find-func rx yasnippet
company-shell subr-x company-dict company-oddmuse company-keywords
company-etags etags xref project company-gtags company-files
company-capf company-cmake company-xcode company-clang company-semantic
company-eclim company-template company-css company-nxml
company-dabbrev-code company-dabbrev company-yasnippet company-bbdb
company evil-surround evil-visualstar key-chord evil-matchit evil
evil-integration evil-maps evil-commands evil-jumps evil-command-window
evil-types evil-search evil-ex evil-macros evil-repeat evil-states
evil-core evil-common rect evil-digraphs evil-vars undo-tree diff
recentf tree-widget wid-edit flx-ido flx ido ag vc-svn compile comint
ansi-color find-dired dired swiper ivy delsel ffap url-parse auth-source
eieio eieio-core gnus-util mm-util help-fns mail-prsvr password-cache
url-vars framemove windmove smartparens-config smartparens thingatpt
paren autorevert filenotify fold-dwim-org fold-dwim hideshow noutline
outline linum bind-map edmacro kmacro winner ring solarized-theme
solarized-definitions cl-macs theme-changer solar cal-dst cal-menu
calendar cal-loaddefs cl cl-seq smart-mode-line-respectful-theme
smart-mode-line rich-minority s dash exec-path-from-shell use-package
diminish bind-key easy-mmode finder-inf advice info package epg-config
seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv
cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win ucs-normalize
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
kqueue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 634898 509781)
 (symbols 48 43976 0)
 (miscs 40 160 666)
 (strings 32 98454 274104)
 (string-bytes 1 2999645)
 (vectors 16 96016)
 (vector-slots 8 2833408 523854)
 (floats 8 10216 14696)
 (intervals 56 2028 655)
 (buffers 976 14))

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> From: ja.nguyen@gmail.com
> Date: Sun, 12 Jun 2016 10:19:23 -0700
> 
> Line number is displayed in fringe and gets cut off when scrolling.

Please tell more, or show a screenshot.  What line numbers are those
-- the ones created by linum-mode, or something else?  Do you have a
recipe starting from "emacs -Q" for reproducing the problem?

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> From: James Nguyen <ja.nguyen@gmail.com>
> Date: Sun, 12 Jun 2016 11:03:50 -0700
> 
> https://dl.dropboxusercontent.com/u/11400324/numberbug.mov

I cannot play this.  Any chance to get some more popular format?  An
image is enough, no need for a movie.

> I will see if I can get a recipe with emacs -Q at some point if time allows.

Thanks.

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Alan Third]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On Sun, Jun 12, 2016 at 10:53:06PM +0300, Eli Zaretskii wrote:
> > From: James Nguyen <ja.nguyen@gmail.com>
> > Date: Sun, 12 Jun 2016 11:03:50 -0700
> > 
> > https://dl.dropboxusercontent.com/u/11400324/numberbug.mov
> 
> I cannot play this.  Any chance to get some more popular format?  An
> image is enough, no need for a movie.

I've attached a screenshot from the movie. It looks like there's some
custom modeline stuff going on that draws the line-number at the
extreme left. If the number gets large enough it overflows into the
fringe where it's then left because that particular part rarely gets
redrawn.

It looks to me like there are two problems:

 1. Whatever is writing the number shouldn't be trying to draw that
    far left.

 2. That part of the screen shouldn't be writable. I recently fixed a
    problem with the cursor intruding into the fringe. I expect this
    is similar.

I'll have a look into number 2, but I don't know where to start with
number 1.
-- 
Alan Third

[-- Attachment #2: overflowing modeline --]
[-- Type: image/png, Size: 30372 bytes --]

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

I’m using this package.

https://github.com/Malabarba/smart-mode-line <https://github.com/Malabarba/smart-mode-line>

> On Jun 12, 2016, at 2:50 PM, Alan Third <alan@idiocy.org> wrote:
> 
> On Sun, Jun 12, 2016 at 10:53:06PM +0300, Eli Zaretskii wrote:
>>> From: James Nguyen <ja.nguyen@gmail.com>
>>> Date: Sun, 12 Jun 2016 11:03:50 -0700
>>> 
>>> https://dl.dropboxusercontent.com/u/11400324/numberbug.mov
>> 
>> I cannot play this.  Any chance to get some more popular format?  An
>> image is enough, no need for a movie.
> 
> I've attached a screenshot from the movie. It looks like there's some
> custom modeline stuff going on that draws the line-number at the
> extreme left. If the number gets large enough it overflows into the
> fringe where it's then left because that particular part rarely gets
> redrawn.
> 
> It looks to me like there are two problems:
> 
> 1. Whatever is writing the number shouldn't be trying to draw that
>    far left.
> 
> 2. That part of the screen shouldn't be writable. I recently fixed a
>    problem with the cursor intruding into the fringe. I expect this
>    is similar.
> 
> I'll have a look into number 2, but I don't know where to start with
> number 1.
> -- 
> Alan Third
> <Screen Shot 2016-06-12 at 22.39.48.png>


[-- Attachment #2: Type: text/html, Size: 2435 bytes --]

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> Date: Sun, 12 Jun 2016 22:50:37 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: James Nguyen <ja.nguyen@gmail.com>, 23755@debbugs.gnu.org
> 
> I've attached a screenshot from the movie.

Thanks.

> It looks like there's some custom modeline stuff going on that draws
> the line-number at the extreme left. If the number gets large enough
> it overflows into the fringe where it's then left because that
> particular part rarely gets redrawn.

There's no fringe on the mode line.  The mode line is drawn to the
full width of the window, so the fringe is not relevant to it.

> It looks to me like there are two problems:
> 
>  1. Whatever is writing the number shouldn't be trying to draw that
>     far left.

Not sure I agree, see above.  I just don't understand what is drawn
there: is it "4:25"? or is the "4:" part a left-over from previous
redisplay?

It would still be useful to have a recipe starting with "emacs -Q",
the OP promised to try to provide that.

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]

I realize that the emacs -Q wouldn't be effective since the line number is
in the middle of the mode line. With that package installed and used, the
line number gets moved to the far left towards the left fringe.

On Sun, Jun 12, 2016 at 9:00 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Sun, 12 Jun 2016 22:50:37 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: James Nguyen <ja.nguyen@gmail.com>, 23755@debbugs.gnu.org
> >
> > I've attached a screenshot from the movie.
>
> Thanks.
>
> > It looks like there's some custom modeline stuff going on that draws
> > the line-number at the extreme left. If the number gets large enough
> > it overflows into the fringe where it's then left because that
> > particular part rarely gets redrawn.
>
> There's no fringe on the mode line.  The mode line is drawn to the
> full width of the window, so the fringe is not relevant to it.
>
> > It looks to me like there are two problems:
> >
> >  1. Whatever is writing the number shouldn't be trying to draw that
> >     far left.
>
> Not sure I agree, see above.  I just don't understand what is drawn
> there: is it "4:25"? or is the "4:" part a left-over from previous
> redisplay?
>
> It would still be useful to have a recipe starting with "emacs -Q",
> the OP promised to try to provide that.
>



-- 
James N.

[-- Attachment #2: Type: text/html, Size: 2119 bytes --]

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Alan Third]

On Mon, Jun 13, 2016 at 07:00:29AM +0300, Eli Zaretskii wrote:
> There's no fringe on the mode line.  The mode line is drawn to the
> full width of the window, so the fringe is not relevant to it.

Good point.

> > It looks to me like there are two problems:
> > 
> >  1. Whatever is writing the number shouldn't be trying to draw that
> >     far left.
> 
> Not sure I agree, see above.  I just don't understand what is drawn
> there: is it "4:25"? or is the "4:" part a left-over from previous
> redisplay?

That's left over from a previous redisplay.

-- 
Alan Third

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> From: James Nguyen <ja.nguyen@gmail.com>
> Date: Sun, 12 Jun 2016 21:01:54 -0700
> Cc: Alan Third <alan@idiocy.org>, 23755@debbugs.gnu.org
> 
> I realize that the emacs -Q wouldn't be effective since the line number is in the middle of the mode line. With
> that package installed and used, the line number gets moved to the far left towards the left fringe.

I understand that some non-default settings are needed, but just
loading the package doesn't reproduce the problem on my system.  So we
would like a precise recipe, something like

 emacs -Q
 load package X
 do something
 do something else
 observe the problem in the mode line

Can you come up with something like that?  It is important to reduce
the number of extra packages and "do something"s to the absolute
minimum, so that the problem could be more easily identified.

Thanks.

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> Date: Mon, 13 Jun 2016 08:18:44 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: ja.nguyen@gmail.com, 23755@debbugs.gnu.org
> 
> > >  1. Whatever is writing the number shouldn't be trying to draw that
> > >     far left.
> > 
> > Not sure I agree, see above.  I just don't understand what is drawn
> > there: is it "4:25"? or is the "4:" part a left-over from previous
> > redisplay?
> 
> That's left over from a previous redisplay.

Thought so, thanks.  Still, just loading the package and activating it
doesn't reproduce the problem on my system, so something else is at
work here.

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

Ping!  Any news on this one?

> Date: Mon, 13 Jun 2016 16:48:39 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: alan@idiocy.org, 23755@debbugs.gnu.org
> 
> > From: James Nguyen <ja.nguyen@gmail.com>
> > Date: Sun, 12 Jun 2016 21:01:54 -0700
> > Cc: Alan Third <alan@idiocy.org>, 23755@debbugs.gnu.org
> > 
> > I realize that the emacs -Q wouldn't be effective since the line number is in the middle of the mode line. With
> > that package installed and used, the line number gets moved to the far left towards the left fringe.
> 
> I understand that some non-default settings are needed, but just
> loading the package doesn't reproduce the problem on my system.  So we
> would like a precise recipe, something like
> 
>  emacs -Q
>  load package X
>  do something
>  do something else
>  observe the problem in the mode line
> 
> Can you come up with something like that?  It is important to reduce
> the number of extra packages and "do something"s to the absolute
> minimum, so that the problem could be more easily identified.
> 
> Thanks.
> 
> 
> 
> 

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

Sorry, didn’t realize there was an email I missed.

I’ll try to cook up a recipe this weekend or sometime next week.

> On Jun 16, 2016, at 8:17 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> Ping!  Any news on this one?
> 
>> Date: Mon, 13 Jun 2016 16:48:39 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: alan@idiocy.org, 23755@debbugs.gnu.org
>> 
>>> From: James Nguyen <ja.nguyen@gmail.com>
>>> Date: Sun, 12 Jun 2016 21:01:54 -0700
>>> Cc: Alan Third <alan@idiocy.org>, 23755@debbugs.gnu.org
>>> 
>>> I realize that the emacs -Q wouldn't be effective since the line number is in the middle of the mode line. With
>>> that package installed and used, the line number gets moved to the far left towards the left fringe.
>> 
>> I understand that some non-default settings are needed, but just
>> loading the package doesn't reproduce the problem on my system.  So we
>> would like a precise recipe, something like
>> 
>> emacs -Q
>> load package X
>> do something
>> do something else
>> observe the problem in the mode line
>> 
>> Can you come up with something like that?  It is important to reduce
>> the number of extra packages and "do something"s to the absolute
>> minimum, so that the problem could be more easily identified.
>> 
>> Thanks.
>> 
>> 
>> 
>> 

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

A combination of that package (smart-mode-line) and setting a box around the mode line is what does it.

  (defun j/make-modeline-taller ()
    "Make the mode line taller."
    (dolist (sym '(mode-line mode-line-inactive))
      (set-face-attribute
       sym nil
       :box `(:line-width 2 :color ,(face-attribute `,sym :background)))))

> On Jun 16, 2016, at 8:17 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> Ping!  Any news on this one?
> 
>> Date: Mon, 13 Jun 2016 16:48:39 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: alan@idiocy.org, 23755@debbugs.gnu.org
>> 
>>> From: James Nguyen <ja.nguyen@gmail.com>
>>> Date: Sun, 12 Jun 2016 21:01:54 -0700
>>> Cc: Alan Third <alan@idiocy.org>, 23755@debbugs.gnu.org
>>> 
>>> I realize that the emacs -Q wouldn't be effective since the line number is in the middle of the mode line. With
>>> that package installed and used, the line number gets moved to the far left towards the left fringe.
>> 
>> I understand that some non-default settings are needed, but just
>> loading the package doesn't reproduce the problem on my system.  So we
>> would like a precise recipe, something like
>> 
>> emacs -Q
>> load package X
>> do something
>> do something else
>> observe the problem in the mode line
>> 
>> Can you come up with something like that?  It is important to reduce
>> the number of extra packages and "do something"s to the absolute
>> minimum, so that the problem could be more easily identified.
>> 
>> Thanks.
>> 
>> 
>> 
>> 

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> From: James Nguyen <ja.nguyen@gmail.com>
> Date: Thu, 16 Jun 2016 22:50:56 -0700
> Cc: Alan Third <alan@idiocy.org>,
>  23755@debbugs.gnu.org
> 
> A combination of that package (smart-mode-line) and setting a box around the mode line is what does it.
> 
>   (defun j/make-modeline-taller ()
>     "Make the mode line taller."
>     (dolist (sym '(mode-line mode-line-inactive))
>       (set-face-attribute
>        sym nil
>        :box `(:line-width 2 :color ,(face-attribute `,sym :background)))))

Sorry, still not reproducible.  Maybe there's something else to be
done?  Here's the complete recipe I used, after downloading
smart-mode-line and rich-minority which it requires:

  emacs -Q
  (add-to-list 'load-path "/path/to/smart-mode-line-master")
  (load-library "smart-mode-line")
  (sml/setup)
  (dolist (sym '(mode-line mode-line-inactive))
        (set-face-attribute
         sym nil
         :box `(:line-width 2 :color ,(face-attribute `,sym :background))))

I see no display problems in the mode line after the above.

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Sorry, I should’ve been more thorough (commenting out that line fixed the problem for me in my setup). I’ll try to get a complete recipe up.

> On Jun 17, 2016, at 12:21 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>  emacs -Q
>  (add-to-list 'load-path "/path/to/smart-mode-line-master")
>  (load-library "smart-mode-line")
>  (sml/setup)
>  (dolist (sym '(mode-line mode-line-inactive))
>        (set-face-attribute
>         sym nil
>         :box `(:line-width 2 :color ,(face-attribute `,sym :background))))


[-- Attachment #2: Type: text/html, Size: 6173 bytes --]

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Alan Third]

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

On Fri, Jun 17, 2016 at 10:21:01AM +0300, Eli Zaretskii wrote:
> Sorry, still not reproducible.  Maybe there's something else to be
> done?  Here's the complete recipe I used, after downloading
> smart-mode-line and rich-minority which it requires:
> 
>   emacs -Q
>   (add-to-list 'load-path "/path/to/smart-mode-line-master")
>   (load-library "smart-mode-line")
>   (sml/setup)
>   (dolist (sym '(mode-line mode-line-inactive))
>         (set-face-attribute
>          sym nil
>          :box `(:line-width 2 :color ,(face-attribute `,sym :background))))
> 
> I see no display problems in the mode line after the above.

I just tried this on the NS port and it leaves stuff behind. The line
number goes over into that left-hand section, which is fine since it's
not the fringe.

Aside from that, the digits seem to be placed wrongly. Sometimes
they're fine, other times they're all wonky. I've attached a
screenshot where it's displaying 404, but it looks like the 0 is too
far left, and the second 4 is cut off, and another screenshot after I
paged down and you can still see the left edge of the zero.

I don't see any other characters that are obviously displayed wrong.

I don't know how to tell what font it is, but I suspect it's
variable-width and Emacs doesn't notice when they change size. For
example, the misplaced 0 in 404 occurs after scrolling from a number
starting with 3, and the 3 appears to be narrower than the 4. The
second digit doesn't move right to compensate for the larger first
digit. When it finally does move, it leaves artifacts behind.

Changing line-width to 1 in your code fixes it.
-- 
Alan Third

[-- Attachment #2: dodgy character positioning --]
[-- Type: image/png, Size: 13088 bytes --]

[-- Attachment #3: after scrolling down --]
[-- Type: image/png, Size: 10959 bytes --]

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

The font is https://github.com/madmalik/mononoki which I believe is fixed-width.

Alan Third writes:

> On Fri, Jun 17, 2016 at 10:21:01AM +0300, Eli Zaretskii wrote:
>> Sorry, still not reproducible.  Maybe there's something else to be
>> done?  Here's the complete recipe I used, after downloading
>> smart-mode-line and rich-minority which it requires:
>> 
>>   emacs -Q
>>   (add-to-list 'load-path "/path/to/smart-mode-line-master")
>>   (load-library "smart-mode-line")
>>   (sml/setup)
>>   (dolist (sym '(mode-line mode-line-inactive))
>>         (set-face-attribute
>>          sym nil
>>          :box `(:line-width 2 :color ,(face-attribute `,sym :background))))
>> 
>> I see no display problems in the mode line after the above.
>
> I just tried this on the NS port and it leaves stuff behind. The line
> number goes over into that left-hand section, which is fine since it's
> not the fringe.
>
> Aside from that, the digits seem to be placed wrongly. Sometimes
> they're fine, other times they're all wonky. I've attached a
> screenshot where it's displaying 404, but it looks like the 0 is too
> far left, and the second 4 is cut off, and another screenshot after I
> paged down and you can still see the left edge of the zero.
>
> I don't see any other characters that are obviously displayed wrong.
>
> I don't know how to tell what font it is, but I suspect it's
> variable-width and Emacs doesn't notice when they change size. For
> example, the misplaced 0 in 404 occurs after scrolling from a number
> starting with 3, and the 3 appears to be narrower than the 4. The
> second digit doesn't move right to compensate for the larger first
> digit. When it finally does move, it leaves artifacts behind.
>
> Changing line-width to 1 in your code fixes it.


-- 
James Nguyen

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Alan Third]

On Fri, Jun 17, 2016 at 10:48:51AM -0700, James Nguyen wrote:
> 
> The font is https://github.com/madmalik/mononoki which I believe is fixed-width.
> 
> > I don't know how to tell what font it is, but I suspect it's
> > variable-width and Emacs doesn't notice when they change size.

Yeah, I realised after typing that that it probably has nothing to do
with the width of the characters, and everything to do with Emacs not
handling the larger box round the modeline.

And FWIW, I'm using a different font. It's probably Menlo, which is
also fixed-width.

-- 
Alan Third

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[James Nguyen]

Do we still need a recipe from me if Alan can reproduce this?

Alan Third writes:

> On Fri, Jun 17, 2016 at 10:48:51AM -0700, James Nguyen wrote:
>> 
>> The font is https://github.com/madmalik/mononoki which I believe is fixed-width.
>> 
>> > I don't know how to tell what font it is, but I suspect it's
>> > variable-width and Emacs doesn't notice when they change size.
>
> Yeah, I realised after typing that that it probably has nothing to do
> with the width of the characters, and everything to do with Emacs not
> handling the larger box round the modeline.
>
> And FWIW, I'm using a different font. It's probably Menlo, which is
> also fixed-width.


-- 
James Nguyen

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> Date: Fri, 17 Jun 2016 18:41:34 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: James Nguyen <ja.nguyen@gmail.com>, 23755@debbugs.gnu.org
> 
> >   emacs -Q
> >   (add-to-list 'load-path "/path/to/smart-mode-line-master")
> >   (load-library "smart-mode-line")
> >   (sml/setup)
> >   (dolist (sym '(mode-line mode-line-inactive))
> >         (set-face-attribute
> >          sym nil
> >          :box `(:line-width 2 :color ,(face-attribute `,sym :background))))
> > 
> > I see no display problems in the mode line after the above.
> 
> I just tried this on the NS port and it leaves stuff behind.

Then I guess it's either NS-specific or specific to the fonts you are
using.

> Aside from that, the digits seem to be placed wrongly. Sometimes
> they're fine, other times they're all wonky. I've attached a
> screenshot where it's displaying 404, but it looks like the 0 is too
> far left, and the second 4 is cut off, and another screenshot after I
> paged down and you can still see the left edge of the zero.

So what, the NS port cannot even display text correctly?

> I don't know how to tell what font it is, but I suspect it's
> variable-width and Emacs doesn't notice when they change size.

That cannot be true in general, since Emacs displays variable-pitch
fonts correctly since v21.1.

> For example, the misplaced 0 in 404 occurs after scrolling from a
> number starting with 3, and the 3 appears to be narrower than the
> 4. The second digit doesn't move right to compensate for the larger
> first digit.

That can only happen if the font lies to Emacs about the dimensions of
the character glyphs.

> Changing line-width to 1 in your code fixes it.

Which means the font does NOT lie, and thus the fact that some
characters are narrower than others is NOT the reason.

bug#23755: 25.0.95; Emacs 25.0.95 Line number is in fringe

[Eli Zaretskii]

> From: James Nguyen <ja.nguyen@gmail.com>
> Cc: James Nguyen <ja.nguyen@gmail.com>, Eli Zaretskii <eliz@gnu.org>, 23755@debbugs.gnu.org
> Date: Fri, 17 Jun 2016 12:56:06 -0700
> 
> 
> Do we still need a recipe from me if Alan can reproduce this?

If Alan can debug this, no.  If I need to debug this, yes.

Btw, did previous versions of Emacs and/or previous pretests of 25.1
have the same problem, or is this new with 25.0.95?

bug#23755: [PATCH] Move text line right when in box (bug#23755)

[Alan Third]

* src/nsterm.m (ns_draw_glyph_string_foreground): Create to take
CHAR_GLYPH specific code and move glyphs right if within a box.
(ns_draw_glyph_string): Move CHAR_GLYPH specific code into above
function.
---
 src/nsterm.m | 38 ++++++++++++++++++++++++++++----------
 1 file changed, 28 insertions(+), 10 deletions(-)

diff --git a/src/nsterm.m b/src/nsterm.m
index f2b0d90..eba75f1 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -3640,6 +3640,32 @@ overwriting cursor (usually when cursor on a tab) */
 
 
 static void
+ns_draw_glyph_string_foreground (struct glyph_string *s)
+{
+  int x, flags;
+  struct font *font = s->font;
+
+  /* If first glyph of S has a left box line, start drawing the text
+     of S to the right of that box line.  */
+  if (s->face && s->face->box != FACE_NO_BOX
+      && s->first_glyph->left_box_line_p)
+    x = s->x + eabs (s->face->box_line_width);
+  else
+    x = s->x;
+
+  flags = s->hl == DRAW_CURSOR ? NS_DUMPGLYPH_CURSOR :
+    (s->hl == DRAW_MOUSE_FACE ? NS_DUMPGLYPH_MOUSEFACE :
+     (s->for_overlaps ? NS_DUMPGLYPH_FOREGROUND :
+      NS_DUMPGLYPH_NORMAL));
+
+  font->driver->draw
+    (s, s->cmp_from, s->nchars, x, s->ybase,
+     (flags == NS_DUMPGLYPH_NORMAL && !s->background_filled_p)
+     || flags == NS_DUMPGLYPH_MOUSEFACE);
+}
+
+
+static void
 ns_draw_composite_glyph_string_foreground (struct glyph_string *s)
 {
   int i, j, x;
@@ -3737,7 +3763,7 @@ overwriting cursor (usually when cursor on a tab) */
 {
   /* TODO (optimize): focus for box and contents draw */
   NSRect r[2];
-  int n, flags;
+  int n;
   char box_drawn_p = 0;
   struct font *font = s->face->font;
   if (! font) font = FRAME_FONT (s->f);
@@ -3807,11 +3833,6 @@ overwriting cursor (usually when cursor on a tab) */
         ns_maybe_dumpglyphs_background
           (s, s->first_glyph->type == COMPOSITE_GLYPH);
 
-      flags = s->hl == DRAW_CURSOR ? NS_DUMPGLYPH_CURSOR :
-        (s->hl == DRAW_MOUSE_FACE ? NS_DUMPGLYPH_MOUSEFACE :
-         (s->for_overlaps ? NS_DUMPGLYPH_FOREGROUND :
-          NS_DUMPGLYPH_NORMAL));
-
       if (s->hl == DRAW_CURSOR && s->w->phys_cursor_type == FILLED_BOX_CURSOR)
         {
           unsigned long tmp = NS_FACE_BACKGROUND (s->face);
@@ -3825,10 +3846,7 @@ overwriting cursor (usually when cursor on a tab) */
         if (isComposite)
           ns_draw_composite_glyph_string_foreground (s);
         else
-          font->driver->draw
-            (s, s->cmp_from, s->nchars, s->x, s->ybase,
-             (flags == NS_DUMPGLYPH_NORMAL && !s->background_filled_p)
-             || flags == NS_DUMPGLYPH_MOUSEFACE);
+          ns_draw_glyph_string_foreground (s);
       }
 
       {
-- 
Looks like the NS port doesn't take a surrounding box into account
when displaying normal glyphs (but does with composite glyphs...). I
don't know why I could see the digits move left and right as I
scrolled, but this patch fixes the problem for me.
-- 
Alan Third

bug#23755: [PATCH] Move text line right when in box (bug#23755)

[Eli Zaretskii]

> Date: Sat, 18 Jun 2016 00:17:50 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: James Nguyen <ja.nguyen@gmail.com>, Eli Zaretskii <eliz@gnu.org>
> 
> Looks like the NS port doesn't take a surrounding box into account
> when displaying normal glyphs (but does with composite glyphs...). I
> don't know why I could see the digits move left and right as I
> scrolled, but this patch fixes the problem for me.

Thanks.  I cannot judge this, so please wait for a few days, and if no
comments or objections are posted, please push to master.

bug#23755: [PATCH] Move text line right when in box (bug#23755)

[Alan Third]

On Sat, Jun 18, 2016 at 11:22:29AM +0300, Eli Zaretskii wrote:
> > Date: Sat, 18 Jun 2016 00:17:50 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: James Nguyen <ja.nguyen@gmail.com>, Eli Zaretskii <eliz@gnu.org>
> > 
> > Looks like the NS port doesn't take a surrounding box into account
> > when displaying normal glyphs (but does with composite glyphs...). I
> > don't know why I could see the digits move left and right as I
> > scrolled, but this patch fixes the problem for me.
> 
> Thanks.  I cannot judge this, so please wait for a few days, and if no
> comments or objections are posted, please push to master.

Pushed to master, so I'm closing this bug report.
-- 
Alan Third