From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request Date: Thu, 11 Aug 2016 17:47:37 +0300 Message-ID: <83lh03fjli.fsf@gnu.org> References: <83d1ltq3p6.fsf@gnu.org> <83popsocg8.fsf@gnu.org> <7fb3540a-7b74-68cf-2c63-66474de26640@yandex.ru> <83mvkvmbv2.fsf@gnu.org> <27168f12-32d2-cb38-45c0-27d3339c75aa@yandex.ru> <83twf0lb5s.fsf@gnu.org> <83lh07i6g3.fsf@gnu.org> <83k2fri5kc.fsf@gnu.org> <87oa53i3si.fsf@linux-m68k.org> <83bn13i2x2.fsf@gnu.org> <87fuqfhy0q.fsf@linux-m68k.org> <837fbqise6.fsf@gnu.org> <834m6uhu87.fsf@gnu.org> <65f6508f-a464-7f66-fd14-1372dce86aa7@yandex.ru> <83bn10hetr.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1470926971 21272 195.159.176.226 (11 Aug 2016 14:49:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Aug 2016 14:49:31 +0000 (UTC) Cc: stakemorii@gmail.com, larsi@gnus.org, schwab@linux-m68k.org, 24117@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 11 16:49:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXrIO-0005CY-48 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Aug 2016 16:49:20 +0200 Original-Received: from localhost ([::1]:48961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXrIK-0007NP-V2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Aug 2016 10:49:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXrIC-0007KD-1W for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 10:49:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXrI6-0005bD-Ew for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 10:49:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXrI6-0005b9-BX for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 10:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bXrI6-0000k7-5x for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Aug 2016 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24117-submit@debbugs.gnu.org id=B24117.14709268892793 (code B ref 24117); Thu, 11 Aug 2016 14:49:02 +0000 Original-Received: (at 24117) by debbugs.gnu.org; 11 Aug 2016 14:48:09 +0000 Original-Received: from localhost ([127.0.0.1]:54157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXrHB-0000it-AU for submit@debbugs.gnu.org; Thu, 11 Aug 2016 10:48:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXrH5-0000iI-Ug for 24117@debbugs.gnu.org; Thu, 11 Aug 2016 10:48:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXrGv-0005Qj-Kh for 24117@debbugs.gnu.org; Thu, 11 Aug 2016 10:47:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXrGv-0005Qd-HD; Thu, 11 Aug 2016 10:47:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1627 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bXrGt-0008Oa-NG; Thu, 11 Aug 2016 10:47:48 -0400 In-reply-to: (message from Dmitry Gutov on Thu, 11 Aug 2016 05:52:42 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122076 Archived-At: > Cc: stakemorii@gmail.com, larsi@gnus.org, schwab@linux-m68k.org, > 24117@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 11 Aug 2016 05:52:42 +0300 > > >> On the master branch, host is passed through IDNA encoding, but > >> real-fname is untouched. On emacs-25, I think we should convert both > >> to unibyte. > > > > Not sure I understand why there should be a difference between the two > > branches. Encoding an ASCII string doesn't do any harm. > > Since it's ASCII, using utf-8 there seems misleading to me. It's a > question of readability. But AFAIU it doesn't have to be ASCII, it could include non-ASCII characters, no? > As a bonus, using us-ascii will validate that the strings indeed do > not contain any unexpected characters. If we did allow non-ASCII characters until now, we will definitely hear from someone who'd say this is a regression. > Thanks. Attaching a patch, it seems to work well enough. LGTM, modulo the considerations about the encoding. Thanks.