From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18716: Patch for this bug Date: Wed, 09 Nov 2016 21:36:14 +0200 Message-ID: <83lgwsfntd.fsf@gnu.org> References: <8761fm903w.fsf@sc3d.org> <83a8d9hh62.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1478720269 29398 195.159.176.226 (9 Nov 2016 19:37:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 Nov 2016 19:37:49 +0000 (UTC) Cc: 18716@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 09 20:37:44 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4YgM-0003je-RS for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Nov 2016 20:37:14 +0100 Original-Received: from localhost ([::1]:42093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4YgP-000128-Tj for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Nov 2016 14:37:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4YgF-00011A-0p for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2016 14:37:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4YgA-0000st-DX for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2016 14:37:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4YgA-0000sp-AJ for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2016 14:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c4YgA-0000o7-2o for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2016 14:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2016 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18716-submit@debbugs.gnu.org id=B18716.14787202063077 (code B ref 18716); Wed, 09 Nov 2016 19:37:02 +0000 Original-Received: (at 18716) by debbugs.gnu.org; 9 Nov 2016 19:36:46 +0000 Original-Received: from localhost ([127.0.0.1]:51227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Yfu-0000nZ-BZ for submit@debbugs.gnu.org; Wed, 09 Nov 2016 14:36:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Yfs-0000nN-Is for 18716@debbugs.gnu.org; Wed, 09 Nov 2016 14:36:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Yfi-0000nn-P2 for 18716@debbugs.gnu.org; Wed, 09 Nov 2016 14:36:39 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Yfi-0000nj-LL; Wed, 09 Nov 2016 14:36:34 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4184 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c4Yfg-00020O-67; Wed, 09 Nov 2016 14:36:34 -0500 In-reply-to: (message from Reuben Thomas on Tue, 8 Nov 2016 22:16:45 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125526 Archived-At: > From: Reuben Thomas > Date: Tue, 8 Nov 2016 22:16:45 +0000 > Cc: 18716@debbugs.gnu.org > > I don't understand what happened to the comment about *.JPG files on > case-sensitive filesystems, > > I took it into account. My experience is that on a case-insensitive system (e.g. a GNU system), one finds > occasional files like this, typically copied from other systems or extracted from archives. These are not a > problem for dired-omit-mode. For visiting such files, treating auto-mode-alist and similar case-insensitively is > no problem. Sorry, I don't understand what you mean by "these are not a problem". With your change, *.JPG files will no longer be treated like *.jpg on Posix systems. Won't people who want *.JPG hidden complain? IOW, isn't this change backward-incompatible? > + (case-fold-search (memq system-type '(windows-nt cygwin)))) The list should include ms-dos as well. > * lisp/dired-x.el (Commentary): Remove USAGE section explaining how to > use dired-x from .emacs. It is now fully customizable. > * lisp/dired-x.el (dired-guess-shell-alist-user): Remove explanation of > how to set this custom variable in .emacs. It should be customized. Why remove these comments? The existence of Custom doesn't preclude people from customizations in plain Lisp. Thanks.