From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Date: Sun, 22 Jan 2017 21:06:15 +0200 Message-ID: <83lgu252zc.fsf@gnu.org> References: <871svzzcn4.fsf@gmail.com> <83lgu76nuf.fsf@gnu.org> <87vatac0a2.fsf@gmail.com> <83a8am6u6q.fsf@gnu.org> <87y3y6ezge.fsf@gmail.com> <8337gd7udo.fsf@gnu.org> <87o9z1n4o3.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1485112056 21183 195.159.176.226 (22 Jan 2017 19:07:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jan 2017 19:07:36 +0000 (UTC) Cc: 25482@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 22 20:07:27 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVNTo-0003QB-OJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jan 2017 20:07:08 +0100 Original-Received: from localhost ([::1]:37414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVNTt-0002Wv-UP for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jan 2017 14:07:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVNTn-0002Wp-GP for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2017 14:07:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVNTi-0005aH-H5 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2017 14:07:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cVNTi-0005aD-DK for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2017 14:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cVNTi-000224-4o for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2017 14:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jan 2017 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25482 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25482-submit@debbugs.gnu.org id=B25482.14851119947776 (code B ref 25482); Sun, 22 Jan 2017 19:07:02 +0000 Original-Received: (at 25482) by debbugs.gnu.org; 22 Jan 2017 19:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:38465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVNTF-00021M-W5 for submit@debbugs.gnu.org; Sun, 22 Jan 2017 14:06:34 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVNTD-000218-QE for 25482@debbugs.gnu.org; Sun, 22 Jan 2017 14:06:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVNT3-0005Nl-Js for 25482@debbugs.gnu.org; Sun, 22 Jan 2017 14:06:26 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVNT3-0005Nd-Gq; Sun, 22 Jan 2017 14:06:21 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cVNT2-00089E-Ck; Sun, 22 Jan 2017 14:06:21 -0500 In-reply-to: <87o9z1n4o3.fsf@gmail.com> (message from Thierry Volpiatto on Fri, 20 Jan 2017 16:16:34 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128313 Archived-At: > From: Thierry Volpiatto > Cc: 25482@debbugs.gnu.org > Date: Fri, 20 Jan 2017 16:16:34 +0100 > > > Eli Zaretskii writes: > > > I'm asking whether the (fixed) behavior, whereby using setq to change > > the value to " -> " would add the ASCII string " -> " to the > > minibuffer history, would be acceptable. If not, please tell why. > > Would be good, but we will have to modify also > `query-replace--split-string` just for this purpose as it assume the > separator is one char long and have a text property 'separator. I'm afraid we are mis-communicating. The current code uses a null character as the separator, giving it a display property and a separator property. The display property uses a non-ASCII character (→). What I wanted to suggest is to keep the same code, and just allow users to specify the ASCII string " -> " for the display property. That should be much simpler than your proposed patch, and I don't really see how it would add non-ASCII characters to your minibuffer history. It also eliminates the need for making changes in query-replace--split-string. What am I missing? Thanks.