From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: michael_heerdegen@web.de, 25890@debbugs.gnu.org, rasmus@gmx.us
Subject: bug#25890: `color-values` gives wrong value
Date: Sat, 04 Mar 2017 10:43:01 +0200 [thread overview]
Message-ID: <83lgsll9ey.fsf@gnu.org> (raw)
In-Reply-To: <1b96dc61-19bb-486b-a408-c3b3c15e113b@default> (message from Drew Adams on Fri, 3 Mar 2017 13:18:12 -0800 (PST))
> Date: Fri, 3 Mar 2017 13:18:12 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: michael_heerdegen@web.de, 25890@debbugs.gnu.org, rasmus@gmx.us
>
> You said:
>
> > The bug is in hexrgb-int-to-hex: it incorrectly assumes that it should
> > produce the LSB part of the number, while it actually should produce
> > the MSB part.
>
> `hexrgb-int-to-hex' just converts integer RGB to hex RGB.
> And it converts integer 57568 to E0E0, which you now agree
> is correct.
>
> Perhaps you can elaborate a bit on what you think the bug is?
I already did, but you didn't want to hear, claiming that I repeat
myself.
Here it is again: the problem is in hexrgb-int-to-hex. It does this:
(substring (format (concat "%0" (int-to-string nb-digits) "X") int) (- nb-digits))
which assumes that the digits to be produced, if n in the %0nX format
is too small and doesn't allow to produce all of them, are the
least-significant digits of the number. It should instead produce the
most-significant digits. IOW, when #FFFFFF is converted to 16-bit per
color component, it should yield #FF00FF00FF00, not #FFFFFFFFFFFF.
next prev parent reply other threads:[~2017-03-04 8:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<<<87zih7n2yt.fsf@pank.eu>
[not found] ` <<<<83r32jpr8b.fsf@gnu.org>
[not found] ` <<<<87bmtnryqr.fsf@drachen>
[not found] ` <<<<87d1e2tzt5.fsf@pank.eu>
[not found] ` <<<<8337eypb5l.fsf@gnu.org>
[not found] ` <<<<87vartx4qd.fsf@drachen>
[not found] ` <<<<56bad9de-8111-4962-a9e9-2dbf0084e004@default>
[not found] ` <<<<83wpc6la28.fsf@gnu.org>
[not found] ` <<<2cfd6280-34de-4751-b35f-ec7d47a16595@default>
[not found] ` <<<83pohyky8i.fsf@gnu.org>
[not found] ` <<d73ecee8-1b1d-4739-b2b8-e3eb9ecc3ce0@default>
[not found] ` <<83o9xikvop.fsf@gnu.org>
2017-03-03 21:18 ` bug#25890: `color-values` gives wrong value Drew Adams
2017-03-04 8:43 ` Eli Zaretskii [this message]
[not found] <<<<<<87zih7n2yt.fsf@pank.eu>
[not found] ` <<<<<<83r32jpr8b.fsf@gnu.org>
[not found] ` <<<<<<87bmtnryqr.fsf@drachen>
[not found] ` <<<<<<87d1e2tzt5.fsf@pank.eu>
[not found] ` <<<<<<8337eypb5l.fsf@gnu.org>
[not found] ` <<<<<<87vartx4qd.fsf@drachen>
[not found] ` <<<<<<56bad9de-8111-4962-a9e9-2dbf0084e004@default>
[not found] ` <<<<<<83wpc6la28.fsf@gnu.org>
[not found] ` <<<<<2cfd6280-34de-4751-b35f-ec7d47a16595@default>
[not found] ` <<<<<83pohyky8i.fsf@gnu.org>
[not found] ` <<<<d73ecee8-1b1d-4739-b2b8-e3eb9ecc3ce0@default>
[not found] ` <<<<83o9xikvop.fsf@gnu.org>
[not found] ` <<<1b96dc61-19bb-486b-a408-c3b3c15e113b@default>
[not found] ` <<<83lgsll9ey.fsf@gnu.org>
[not found] ` <<59441882-425e-4962-8760-70c505d991dd@default>
[not found] ` <<83lgslja4t.fsf@gnu.org>
2017-03-04 20:40 ` Drew Adams
[not found] <<<<<87zih7n2yt.fsf@pank.eu>
[not found] ` <<<<<83r32jpr8b.fsf@gnu.org>
[not found] ` <<<<<87bmtnryqr.fsf@drachen>
[not found] ` <<<<<87d1e2tzt5.fsf@pank.eu>
[not found] ` <<<<<8337eypb5l.fsf@gnu.org>
[not found] ` <<<<<87vartx4qd.fsf@drachen>
[not found] ` <<<<<56bad9de-8111-4962-a9e9-2dbf0084e004@default>
[not found] ` <<<<<83wpc6la28.fsf@gnu.org>
[not found] ` <<<<2cfd6280-34de-4751-b35f-ec7d47a16595@default>
[not found] ` <<<<83pohyky8i.fsf@gnu.org>
[not found] ` <<<d73ecee8-1b1d-4739-b2b8-e3eb9ecc3ce0@default>
[not found] ` <<<83o9xikvop.fsf@gnu.org>
[not found] ` <<1b96dc61-19bb-486b-a408-c3b3c15e113b@default>
[not found] ` <<83lgsll9ey.fsf@gnu.org>
2017-03-04 15:38 ` Drew Adams
2017-03-04 16:10 ` Eli Zaretskii
[not found] <<<87zih7n2yt.fsf@pank.eu>
[not found] ` <<<83r32jpr8b.fsf@gnu.org>
[not found] ` <<<87bmtnryqr.fsf@drachen>
[not found] ` <<<87d1e2tzt5.fsf@pank.eu>
[not found] ` <<<8337eypb5l.fsf@gnu.org>
[not found] ` <<<87vartx4qd.fsf@drachen>
[not found] ` <<<56bad9de-8111-4962-a9e9-2dbf0084e004@default>
[not found] ` <<<83wpc6la28.fsf@gnu.org>
[not found] ` <<2cfd6280-34de-4751-b35f-ec7d47a16595@default>
[not found] ` <<83pohyky8i.fsf@gnu.org>
2017-03-03 19:20 ` Drew Adams
2017-03-03 19:27 ` Eli Zaretskii
[not found] <<87zih7n2yt.fsf@pank.eu>
[not found] ` <<83r32jpr8b.fsf@gnu.org>
[not found] ` <<87bmtnryqr.fsf@drachen>
[not found] ` <<87d1e2tzt5.fsf@pank.eu>
[not found] ` <<8337eypb5l.fsf@gnu.org>
[not found] ` <<87vartx4qd.fsf@drachen>
[not found] ` <<56bad9de-8111-4962-a9e9-2dbf0084e004@default>
[not found] ` <<83wpc6la28.fsf@gnu.org>
2017-03-03 15:49 ` Drew Adams
2017-03-03 18:32 ` Eli Zaretskii
2017-02-27 14:05 bug#25890: 26.0.50; " Rasmus
2017-02-27 15:51 ` Eli Zaretskii
2017-02-27 17:09 ` bug#25890: " Rasmus
2017-02-27 23:36 ` bug#25890: 26.0.50; " Michael Heerdegen
2017-02-28 9:44 ` bug#25890: " Rasmus
2017-02-28 15:50 ` Eli Zaretskii
2017-02-28 23:42 ` Michael Heerdegen
2017-02-28 23:54 ` Drew Adams
2017-03-03 14:16 ` Eli Zaretskii
2017-03-01 3:43 ` Eli Zaretskii
2017-03-01 9:55 ` Rasmus
2017-03-03 14:08 ` Eli Zaretskii
2017-03-04 14:24 ` Simen Heggestøyl
2017-03-04 14:38 ` Eli Zaretskii
2017-03-04 15:44 ` Lars Ingebrigtsen
2017-03-04 16:15 ` Eli Zaretskii
2017-03-10 5:23 ` mail
2017-03-10 7:28 ` Eli Zaretskii
2017-03-10 8:13 ` mail
2017-03-10 8:33 ` mail
2017-03-10 9:28 ` Eli Zaretskii
2017-03-11 10:06 ` mail
2017-03-10 9:25 ` Eli Zaretskii
2017-03-10 11:07 ` Lars Ingebrigtsen
2017-03-10 13:32 ` Eli Zaretskii
2017-03-11 10:08 ` mail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgsll9ey.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25890@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=michael_heerdegen@web.de \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).