From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25895: Remove update-game-score Date: Sun, 12 Mar 2017 17:14:52 +0200 Message-ID: <83lgsacys3.fsf@gnu.org> References: <22722.19177.891745.426221@a1i15.kph.uni-mainz.de> <2d6ba53c-2e0e-9076-4d3e-c79db9243ff6@cs.ucla.edu> <83innge32x.fsf@gnu.org> <310c3892-2719-370b-cd84-072b63d3510a@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1489331779 23799 195.159.176.226 (12 Mar 2017 15:16:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 12 Mar 2017 15:16:19 +0000 (UTC) Cc: ulm@gentoo.org, 25895@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 12 16:16:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn5EB-0005NY-BA for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Mar 2017 16:16:11 +0100 Original-Received: from localhost ([::1]:47318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn5EH-0006vi-7f for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Mar 2017 11:16:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn5E7-0006tO-8P for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 11:16:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn5E2-0007Wm-Pf for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 11:16:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cn5E2-0007Wg-La for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 11:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cn5E2-0005x5-Gc for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2017 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Mar 2017 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25895 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25895-submit@debbugs.gnu.org id=B25895.148933171822812 (code B ref 25895); Sun, 12 Mar 2017 15:16:02 +0000 Original-Received: (at 25895) by debbugs.gnu.org; 12 Mar 2017 15:15:18 +0000 Original-Received: from localhost ([127.0.0.1]:52762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn5DK-0005vs-FK for submit@debbugs.gnu.org; Sun, 12 Mar 2017 11:15:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn5DJ-0005vf-9n for 25895@debbugs.gnu.org; Sun, 12 Mar 2017 11:15:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn5D9-0007Cn-Sg for 25895@debbugs.gnu.org; Sun, 12 Mar 2017 11:15:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn5D9-0007Cf-PY; Sun, 12 Mar 2017 11:15:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2549 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cn5D8-0000KQ-BG; Sun, 12 Mar 2017 11:15:07 -0400 In-reply-to: <310c3892-2719-370b-cd84-072b63d3510a@cs.ucla.edu> (message from Paul Eggert on Sun, 12 Mar 2017 00:45:13 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130517 Archived-At: > Cc: ulm@gentoo.org, 25895@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 12 Mar 2017 00:45:13 -0800 > > Eli Zaretskii wrote: > > > Please add comments to the affected Makefile.in files to explain the > > conditions related to user/group. > > Done in the attached revised patch, which also fixes the bug Ulrich Müller noted. Thanks, but I expected to see there the explanation of why we sometimes expect user/group to be empty and sometimes not. IOW, I'd like to have in the affected Makefile a comment which summarized the rationale in the commit message, something akin to this: > Most distributions do not install update-game-score properly > due to setuid/setgid complications, so install it only when > the installer specifies a user or group (Bug#25895). > > I also don't understand why you unconditionally removed this program > > from the Windows builds and installations: the problem with setgid > > doesn't exist on Windows, so nothing should prevent Windows > > installations from having this program, right? > > It's more the other way round. On platforms without setuid/setgid, Emacs can use > its already-existing code to update the score file itself. The auxiliary program > is needed only on platforms that have setuid/setgid, to avoid the security > problems that would ensue if we made Emacs itself setuid/setgid. Ah, yes. Thanks for clarifying this.