From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex Date: Tue, 30 May 2017 11:38:59 +0300 Message-ID: <83lgpeeo2k.fsf@gnu.org> References: <20170528204250.wjbrm2pul6cf6xam@odonien.localdomain> <83o9ucfl37.fsf@gnu.org> <20170529062859.mwoveygr5oh5iphz@odonien.localdomain> <8360gjfo51.fsf@gnu.org> <20170529201558.yogm76php5fbpz35@odonien.localdomain> <83tw42eua6.fsf@gnu.org> <20170530081628.xwl2ztjnkeqp4m47@odonien.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1496134113 9879 195.159.176.226 (30 May 2017 08:48:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 08:48:33 +0000 (UTC) Cc: 27122@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 30 10:48:27 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFcpH-0002LV-EW for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 10:48:27 +0200 Original-Received: from localhost ([::1]:52302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFcpM-0001AI-Ow for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 04:48:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFchC-0003ZF-T3 for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 04:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFch8-0006TV-2W for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 04:40:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41491) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFch7-0006TN-VY for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 04:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFch7-0002LS-LU for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 04:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 08:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27122-submit@debbugs.gnu.org id=B27122.14961335448937 (code B ref 27122); Tue, 30 May 2017 08:40:01 +0000 Original-Received: (at 27122) by debbugs.gnu.org; 30 May 2017 08:39:04 +0000 Original-Received: from localhost ([127.0.0.1]:44168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFcgC-0002K5-En for submit@debbugs.gnu.org; Tue, 30 May 2017 04:39:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFcgB-0002Jb-C8 for 27122@debbugs.gnu.org; Tue, 30 May 2017 04:39:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFcg1-0006AR-38 for 27122@debbugs.gnu.org; Tue, 30 May 2017 04:38:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFcg1-0006AC-0D; Tue, 30 May 2017 04:38:53 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1935 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dFcg0-0002ub-9P; Tue, 30 May 2017 04:38:52 -0400 In-reply-to: <20170530081628.xwl2ztjnkeqp4m47@odonien.localdomain> (message from Vasilij Schneidermann on Tue, 30 May 2017 10:16:28 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133048 Archived-At: > Date: Tue, 30 May 2017 10:16:28 +0200 > From: Vasilij Schneidermann > Cc: 27122@debbugs.gnu.org > > > OK, please submit the patch with the necessary documentation, and > > please add a test for the original and the new behavior. > > Where and how should this feature be tested? I've found > test/manual/redisplay-testsuite.el for manual testing of xdisp.c > features, but also test/src/textprop.el for automated testing which > suggests test/src/xdisp.el might work out. Yes, I think test/manual/redisplay-testsuite.el is where the additional tests should go. > I've fixed the remaining points. > * src/xdisp.c (get_next_display_element): Dispatch used format string > for unprintables based on new display-raw-bytes-as-hex > variable > (display-raw-bytes-as-hex): New variable > * doc/emacs/display.texi: Document the new variable Please end each sentence in the commit log message with a period, and please mention the bug number there. Please also add a short log entry for etc/NEWS. Thanks.