From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28023: fix make-temp-file race on local host Date: Wed, 09 Aug 2017 22:09:41 +0300 Message-ID: <83lgmssglm.fsf@gnu.org> References: <8c2c16ff-94ec-a691-57b1-bab8f5b39dfb@cs.ucla.edu> <83poc4sp4z.fsf@gnu.org> <2ca18723-8d62-11f7-86d8-3e0fc044ac57@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502305879 11325 195.159.176.226 (9 Aug 2017 19:11:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 Aug 2017 19:11:19 +0000 (UTC) Cc: 28023@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 09 21:11:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfWNo-0002OL-Fa for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Aug 2017 21:11:08 +0200 Original-Received: from localhost ([::1]:49419 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfWNu-0003xH-Po for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Aug 2017 15:11:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfWNn-0003wB-Ry for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 15:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfWNl-0005oy-1t for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 15:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dfWNk-0005on-Ut for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 15:11:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dfWNk-00026y-Nd for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 15:11:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Aug 2017 19:11:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28023 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28023-submit@debbugs.gnu.org id=B28023.15023058538082 (code B ref 28023); Wed, 09 Aug 2017 19:11:04 +0000 Original-Received: (at 28023) by debbugs.gnu.org; 9 Aug 2017 19:10:53 +0000 Original-Received: from localhost ([127.0.0.1]:53631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfWNY-00026G-6M for submit@debbugs.gnu.org; Wed, 09 Aug 2017 15:10:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfWNU-000261-Be for 28023@debbugs.gnu.org; Wed, 09 Aug 2017 15:10:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfWNM-0005T9-9P for 28023@debbugs.gnu.org; Wed, 09 Aug 2017 15:10:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfWNM-0005Sr-5m; Wed, 09 Aug 2017 15:10:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2506 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dfWNC-0005bd-KC; Wed, 09 Aug 2017 15:10:39 -0400 In-reply-to: <2ca18723-8d62-11f7-86d8-3e0fc044ac57@cs.ucla.edu> (message from Paul Eggert on Wed, 9 Aug 2017 11:47:36 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135606 Archived-At: > Cc: 28023@debbugs.gnu.org > From: Paul Eggert > Date: Wed, 9 Aug 2017 11:47:36 -0700 > > On 08/09/2017 09:05 AM, Eli Zaretskii wrote: > > We could resolve this problem by providing a way for the Windows build > > to specify its own replacements for 'open', 'mkdir', and 'lstat' > > (Emacs already have such replacements in w32.c), which tempname.c > > calls, but that would require minor changes in Gnulib's tempname.c. > > This sounds like a better way to go. What minor changes would be needed? > tempname.c already includes config.h, which includes ms-w32.h, which > redefines open, mkdir, and lstat, so I thought it would work as-is. Perhaps you are right, and it will "just work". I will have to try (for now, I just looked at the sources and the changes, but didn't try building). > > This seems to say that we will sometimes use secure_getenv, but the > > relevant code in tempname.c is conditioned on _LIBC, which AFAIU is > > only true when building glibc, so why do we need that? Or did I miss > > something? > No, good catch, Emacs never needs secure_getenv. I fixed Gnulib, > installed the attached patch to propagate that fix, and will adjust the > proposed make-temp-file patch accordingly. Thanks.