From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28814: [BUMP, PATCH] (26.0.90; When *xref* window is needed, original window-switching intent is lost ) Date: Fri, 03 Nov 2017 15:47:22 +0200 Message-ID: <83lgjnv5hx.fsf@gnu.org> References: <87infjm3p3.fsf@gmail.com> <871slyi3lk.fsf_-_@gmail.com> <87lgk22ryu.fsf@gmail.com> <87fua91vis.fsf@gmail.com> <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> <83inf38dq2.fsf@gnu.org> <87k1zjs0xa.fsf@gmail.com> <83fua78ce9.fsf@gnu.org> <87a80fvte2.fsf@gmail.com> <83y3nx7tdn.fsf@gnu.org> <873765wjdr.fsf@gmail.com> <83r2tn6244.fsf@gnu.org> <87o9orulln.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1509716912 1348 195.159.176.226 (3 Nov 2017 13:48:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 13:48:32 +0000 (UTC) Cc: 28814@debbugs.gnu.org, dgutov@yandex.ru To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 03 14:48:24 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcKQ-0007Ip-KX for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 14:48:10 +0100 Original-Received: from localhost ([::1]:36806 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAcKS-0002mX-RR for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 09:48:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAcKM-0002mI-TW for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 09:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAcKI-00009o-9q for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 09:48:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAcKI-00009g-5R for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 09:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eAcKH-0001VH-V3 for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 09:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Nov 2017 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28814-submit@debbugs.gnu.org id=B28814.15097168565746 (code B ref 28814); Fri, 03 Nov 2017 13:48:01 +0000 Original-Received: (at 28814) by debbugs.gnu.org; 3 Nov 2017 13:47:36 +0000 Original-Received: from localhost ([127.0.0.1]:48900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcJr-0001Uc-Vl for submit@debbugs.gnu.org; Fri, 03 Nov 2017 09:47:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcJr-0001UO-9K for 28814@debbugs.gnu.org; Fri, 03 Nov 2017 09:47:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAcJh-0008Fo-Ag for 28814@debbugs.gnu.org; Fri, 03 Nov 2017 09:47:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAcJh-0008Fi-6e; Fri, 03 Nov 2017 09:47:25 -0400 Original-Received: from [176.228.60.248] (port=2067 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAcJg-0004oc-Hf; Fri, 03 Nov 2017 09:47:25 -0400 In-reply-to: <87o9orulln.fsf@gmail.com> (joaotavora@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139413 Archived-At: > From: joaotavora@gmail.com (João Távora) > Cc: dgutov@yandex.ru, 28814@debbugs.gnu.org > Date: Sat, 28 Oct 2017 20:19:00 +0100 > > I hope I fixed everything in these patches. Thanks, let's get this into the emacs-26 branch, after fixing the gotchas below. > diff --git a/etc/NEWS b/etc/NEWS > index 82778932ab..561a15dbd7 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1185,6 +1185,16 @@ New user options `term-char-mode-buffer-read-only' and > are non-nil by default. Customize these options to nil if you want > the previous behavior. > > +** Xref > + > ++++ > +*** When an *xref* buffer is needed, 'TAB' quits and jumps to an xref Please end this sentence with a period. > +A new command 'xref-quit-and-goto-xref', bound to 'TAB' in *xref* > +buffers, quits the window before jumping to the destination. In many ^^ Two spaces between sentences, please. > (defun xref--show-location (location &optional select) > + "Helper for `xref-show-xref' and `xref-goto-xref'. > +Go to LOCATION and if SELECT is non-nil select its window. If > +SELECT is `quit', also quit the *xref* window." The first line of every doc string should be a single complete sentence. > +(defun xref-goto-xref (&optional quit) > + "Jump to the xref on the current line and select its window. > +Non-interactively, non-nil QUIT says to first quit the *xref* ^^^^ "means", not "says"