From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore Date: Fri, 02 Feb 2018 12:42:14 +0200 Message-ID: <83lggbd661.fsf@gnu.org> References: <87a7wxd1g9.fsf@mail.linkov.net> <83607kinmx.fsf@gnu.org> <877erz41re.fsf@tcd.ie> <87zi4tu2ic.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517587895 18972 195.159.176.226 (2 Feb 2018 16:11:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Feb 2018 16:11:35 +0000 (UTC) Cc: contovob@tcd.ie, 30280@debbugs.gnu.org, rrt@sc3d.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 02 17:11:30 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehdvt-000479-12 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Feb 2018 17:11:21 +0100 Original-Received: from localhost ([::1]:38480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehdxs-00038e-8u for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Feb 2018 11:13:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehdH2-0006ru-Kh for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 10:30:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehdFy-0006mh-Ch for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 10:29:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46278) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehdFy-0006mO-52 for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 10:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehdFx-0006Ky-TI for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 10:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Feb 2018 15:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30280 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30280-submit@debbugs.gnu.org id=B30280.151758524724317 (code B ref 30280); Fri, 02 Feb 2018 15:28:01 +0000 Original-Received: (at 30280) by debbugs.gnu.org; 2 Feb 2018 15:27:27 +0000 Original-Received: from localhost ([127.0.0.1]:54175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehdFP-0006K9-EX for submit@debbugs.gnu.org; Fri, 02 Feb 2018 10:27:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehdFN-0006Jx-Re for 30280@debbugs.gnu.org; Fri, 02 Feb 2018 10:27:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehdAk-0000Ja-Ct for 30280@debbugs.gnu.org; Fri, 02 Feb 2018 10:27:20 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehdAj-0007eF-Tp; Fri, 02 Feb 2018 10:22:38 -0500 Original-Received: from [176.228.60.248] (port=3761 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ehYne-00008C-6t; Fri, 02 Feb 2018 05:42:30 -0500 In-reply-to: <87zi4tu2ic.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 31 Jan 2018 23:44:43 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -5.0 (-----) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142797 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , Reuben Thomas , <30280@debbugs.gnu.org> > Date: Wed, 31 Jan 2018 23:44:43 +0200 > > > I attach a patch which addresses both bugs. Its solution for (a) is to > > make the advice disposable, i.e. it removes itself from the process > > filter after it has fulfilled its purpose of displaying the output > > buffer. A syntactically simpler implementation of this could use a > > plain boolean switch instead of removing the advice, but IMO the latter > > is semantically more sound (and possibly more performant in subsequent > > invocations of the process filter, though this should be irrelevant). > > > > WDYT? > > Thanks, I confirm this is the right thing to do and your patch fixes > the reported issue. Then please push them to the emacs-26 branch, and thanks.