From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 29156@debbugs.gnu.org, eric@pagefault.se, ambrevar@gmail.com
Subject: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Sat, 17 Mar 2018 10:58:32 +0200 [thread overview]
Message-ID: <83lgeroz7r.fsf@gnu.org> (raw)
In-Reply-To: <87lgerv8tq.fsf@gmail.com> (message from Noam Postavsky on Fri, 16 Mar 2018 20:34:25 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Fri, 16 Mar 2018 20:34:25 -0400
> Cc: Eric Skoglund <eric@pagefault.se>, Pierre Neidhardt <ambrevar@gmail.com>
>
> > ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg)
> > - (setq signum (abs (string-to-number arg)))))
> > + (setq signum (make-symbol (substring arg 1 (length arg))))))
>
> Not sure this `make-symbol' call, should it rather be `intern'?
Yes, I think intern is better here.
> (Maybe we should update signal-process take a string as well a
> symbol.)
Possibly.
Btw, the doc string of eshell/kill should be updated to reflect the
fact we now support symbolic names of Unix signals. Also, NEWS and
the Eshell manual should be updated.
next prev parent reply other threads:[~2018-03-17 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 11:31 bug#29156: 25.3; eshell/kill does not understand -<signal> Pierre Neidhardt
2017-11-05 12:38 ` Noam Postavsky
2018-03-17 0:21 ` bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME> Noam Postavsky
2018-03-17 0:34 ` Noam Postavsky
2018-03-17 8:58 ` Eli Zaretskii [this message]
2018-03-17 17:43 ` Eric Skoglund
2018-03-17 19:33 ` Eli Zaretskii
[not found] ` <87muz65rh9.fsf@pagefault.se>
2018-03-23 1:05 ` Noam Postavsky
2018-03-23 6:03 ` Eric Skoglund
2018-03-25 15:34 ` Noam Postavsky
2018-03-17 14:43 ` Noam Postavsky
2018-03-17 14:54 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgeroz7r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29156@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
--cc=eric@pagefault.se \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).