From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30874: 27.0.50; Emacs crashes Date: Fri, 30 Mar 2018 16:46:29 +0300 Message-ID: <83lge98ymi.fsf@gnu.org> References: <831sgencgb.fsf@gnu.org> <83woy4i7rz.fsf@gnu.org> <83vadoi2ia.fsf@gnu.org> <878taf2kj5.fsf@gmail.com> <83d0zqg8p8.fsf@gnu.org> <87o9ja230e.fsf@gmail.com> <83605ig2se.fsf@gnu.org> <87fu4m1tht.fsf@gmail.com> <878tae1nzu.fsf@gmail.com> <83lgeedxv7.fsf@gnu.org> <874ll128ww.fsf@gmail.com> <83efk3dvq0.fsf@gnu.org> <87po3mdfl8.fsf@gmail.com> <83sh8idd3p.fsf@gnu.org> <87woxtq282.fsf@gmail.com> <83po3l946g.fsf@gnu.org> <87o9j5pvk4.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1522417509 23159 195.159.176.226 (30 Mar 2018 13:45:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Mar 2018 13:45:09 +0000 (UTC) Cc: 30874@debbugs.gnu.org, jsynacek@redhat.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 30 15:45:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1uL3-0005vG-2s for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Mar 2018 15:45:05 +0200 Original-Received: from localhost ([::1]:38453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1uN6-0002ky-Nv for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Mar 2018 09:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1uMz-0002kD-OD for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 09:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1uMw-0002bA-J1 for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 09:47:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1uMw-0002b6-FE for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 09:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f1uMw-0005tC-5w for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2018 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30874-submit@debbugs.gnu.org id=B30874.152241760722618 (code B ref 30874); Fri, 30 Mar 2018 13:47:02 +0000 Original-Received: (at 30874) by debbugs.gnu.org; 30 Mar 2018 13:46:47 +0000 Original-Received: from localhost ([127.0.0.1]:59567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1uMg-0005sj-6n for submit@debbugs.gnu.org; Fri, 30 Mar 2018 09:46:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1uMe-0005sW-5c for 30874@debbugs.gnu.org; Fri, 30 Mar 2018 09:46:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1uMY-0002Iy-5I for 30874@debbugs.gnu.org; Fri, 30 Mar 2018 09:46:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1uMS-0002CW-Io; Fri, 30 Mar 2018 09:46:32 -0400 Original-Received: from [176.228.60.248] (port=1511 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f1uMS-00060d-00; Fri, 30 Mar 2018 09:46:32 -0400 In-reply-to: <87o9j5pvk4.fsf@gmail.com> (message from Robert Pluim on Fri, 30 Mar 2018 15:00:43 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144742 Archived-At: > From: Robert Pluim > Cc: 30874@debbugs.gnu.org, jsynacek@redhat.com > Date: Fri, 30 Mar 2018 15:00:43 +0200 > > > That part of cleanup_vector is under suspicion since it was born, see > > "git -L" reports about that function. Perhaps the easiest band-aid > > (or maybe it's a real fix) would be to disable this part: > > > > if (PSEUDOVECTOR_TYPEP (&vector->header, PVEC_FONT) > > && ((vector->header.size & PSEUDOVECTOR_SIZE_MASK) > > == FONT_OBJECT_MAX)) > > { > > struct font_driver const *drv = ((struct font *) vector)->driver; > > > > /* The font driver might sometimes be NULL, e.g. if Emacs was > > interrupted before it had time to set it up. */ > > if (drv) > > { > > /* Attempt to catch subtle bugs like Bug#16140. */ > > eassert (valid_font_driver (drv)); > > drv->close ((struct font *) vector); > > } > > } > > > > when the font backend is one of those which use ftfont_close. Or > > maybe just make ftfont_close return without doing anything if it is > > called from GC. > > Iʼll look into that. I assume thereʼs an 'in_gc' variable we can check. Yes, it's called gc_in_progress. > > Symbola I have installed here does have a glyph for that character, > > FWIW. > > Now Iʼm thoroughly confused as to what's happening. Eg LibreOffice > quite happily uses Symbola, so it has the glyph, but I see Emacs > skipping past Symbola until it arrives at VL Gothic. Itʼs not a big > deal though, I doubt itʼs a bug. If VL Gothic has a glyph for that character, it is not a bug. > > If Jan says it does fix the problem, I think we should install this on > > master. What do you think about having this conditioned on a variable > > exposed to Lisp, as a "fire escape" in case there are some situations > > where users might want these fonts anyway? > > I thought Xft had no real support for displaying these fonts anyway? I'm not sure it's about the font, it could be about some glyphs of the font. You are probably right, but IME leaving a variable to get back previous behavior is good policy; at the very least, it makes it easy to ask users who complain about related problems to see if this particular change is the culprit without having to rebuild Emacs. > > Also, we should probably condition this by HAVE_XFT, since AFAIU the > > problem is only relevant to that build? > > I think thatʼs right. At least the cairo build doesnʼt crash with the > reproduction recipe. Thanks.