From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31376: 26.0.50; print-charset-text-property not honored Date: Sun, 13 May 2018 21:51:18 +0300 Message-ID: <83lgcnl789.fsf@gnu.org> References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> <83r2mflgkh.fsf@gnu.org> <87r2mfjtnd.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1526237410 10388 195.159.176.226 (13 May 2018 18:50:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 May 2018 18:50:10 +0000 (UTC) Cc: 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 13 20:50:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHw4L-0002Yb-R8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 20:50:05 +0200 Original-Received: from localhost ([::1]:58103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHw6Q-0001Rs-Oc for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 14:52:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHw6J-0000lI-P3 for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 14:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHw6E-0003u4-W9 for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 14:52:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHw6E-0003tv-Sd for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fHw6E-0001Kc-5E for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.15262375025092 (code B ref 31376); Sun, 13 May 2018 18:52:02 +0000 Original-Received: (at 31376) by debbugs.gnu.org; 13 May 2018 18:51:42 +0000 Original-Received: from localhost ([127.0.0.1]:32769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHw5t-0001K4-NI for submit@debbugs.gnu.org; Sun, 13 May 2018 14:51:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHw5s-0001Jn-0D for 31376@debbugs.gnu.org; Sun, 13 May 2018 14:51:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHw5h-0003o5-VC for 31376@debbugs.gnu.org; Sun, 13 May 2018 14:51:34 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHw5Y-0003lz-0G; Sun, 13 May 2018 14:51:20 -0400 Original-Received: from [176.228.60.248] (port=3721 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHw5X-0006e2-7l; Sun, 13 May 2018 14:51:19 -0400 In-reply-to: <87r2mfjtnd.fsf@gmail.com> (message from Noam Postavsky on Sun, 13 May 2018 14:29:58 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146155 Archived-At: > From: Noam Postavsky > Cc: handa@gnu.org, 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com > Date: Sun, 13 May 2018 14:29:58 -0400 > > > If the value is @code{default}, print only those @code{charset} text > > properties that are ``unusual'' for the respective characters under > > the current language environment. The @code{charset} property of a > > character is considered unusual if its value is different from what > > @code{char-charset} returns for that character. > > Okay, when writing up some tests I may have found another minor bug, or > at least something which contradicts the text above. Is there supposed > to be an exception for ascii characters? Yes, you can see that in print_check_string_charset_prop: charset = XCAR (XCDR (val)); for (i = 0; i < LENGTH (interval); i++) { FETCH_STRING_CHAR_ADVANCE (c, string, charpos, bytepos); if (! ASCII_CHAR_P (c) <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< && ! EQ (CHARSET_NAME (CHAR_CHARSET (c)), charset)) { print_check_string_result |= PRINT_STRING_UNSAFE_CHARSET_FOUND; break; } } CHAR_CHARSET always returns 'ascii' for ASCII characters, while showing 'charset' for ASCII characters probably makes littles sense. Of course, that's only my guess, the default behavior wrt this is pure heuristics, so YMMV. We could mention this exception in the manual.