From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31615: 27.0; doc of `uncomment-region(-default)' Date: Sat, 02 Jun 2018 13:44:59 +0300 Message-ID: <83lgbxeac4.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1527936246 24718 195.159.176.226 (2 Jun 2018 10:44:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 10:44:06 +0000 (UTC) Cc: 31615@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 02 12:44:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP40v-0006Jx-K9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 12:44:01 +0200 Original-Received: from localhost ([::1]:59120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP432-0005O7-HM for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 06:46:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP42w-0005Nr-4b for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 06:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP42s-0000RF-W1 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 06:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP42s-0000Qv-Qx for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 06:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fP42s-0007HZ-Hx for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 06:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jun 2018 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31615-submit@debbugs.gnu.org id=B31615.152793630927921 (code B ref 31615); Sat, 02 Jun 2018 10:46:02 +0000 Original-Received: (at 31615) by debbugs.gnu.org; 2 Jun 2018 10:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:58405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP41y-0007GF-LI for submit@debbugs.gnu.org; Sat, 02 Jun 2018 06:45:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP41w-0007FU-TM for 31615@debbugs.gnu.org; Sat, 02 Jun 2018 06:45:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP41o-0007eW-P0 for 31615@debbugs.gnu.org; Sat, 02 Jun 2018 06:44:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP41o-0007eL-LF; Sat, 02 Jun 2018 06:44:56 -0400 Original-Received: from [176.228.60.248] (port=2120 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fP41o-0005C2-36; Sat, 02 Jun 2018 06:44:56 -0400 In-reply-to: (message from Drew Adams on Sun, 27 May 2018 21:20:04 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146853 Archived-At: > Date: Sun, 27 May 2018 21:20:04 -0700 (PDT) > From: Drew Adams > > 1. These two functions should not have the same doc string. Function > `*-default' should say what is - the default value of > `uncomment-region-function'. Done. > 2. The doc strings should be much more specific about the behavior, in > particular wrt ARG. Apparently the functions do nothing at all if ARG > is larger than the first sequence of comment chars in the region. > > E.g. for a comment such as this one: > > ;; foo bar > > (uncomment-region (line-beginning-position) (line-end-position) 3) > > does nothing. That's not obvious from the doc. I'm not sure this was the intent of the code. I'd expect it to remove the maximum number of comment delimiters it can, not just punt silently. > 3. The doc string talks about "comment markers". What's that? It means "comment delimiters"; fixed. > 4. Enhancement request: Provide a way to remove ALL comment chars and > all whitespace between them, up to the first non-comment char. Not done.