From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src Date: Thu, 02 Aug 2018 17:05:09 +0300 Message-ID: <83lg9ovp7u.fsf@gnu.org> References: <20180717234729.15507-1-eggert@cs.ucla.edu> <83va9c33kk.fsf@gnu.org> <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533218653 23386 195.159.176.226 (2 Aug 2018 14:04:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Aug 2018 14:04:13 +0000 (UTC) Cc: 32194@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 02 16:04:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flED2-0005xo-MK for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Aug 2018 16:04:08 +0200 Original-Received: from localhost ([::1]:45838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flEF9-0005Ze-G5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Aug 2018 10:06:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flEF0-0005ZL-6U for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:06:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flEEs-0005fb-Kl for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:06:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flEEs-0005fM-Fc for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flEEs-00034g-7r for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Aug 2018 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32194-submit@debbugs.gnu.org id=B32194.153321873311782 (code B ref 32194); Thu, 02 Aug 2018 14:06:02 +0000 Original-Received: (at 32194) by debbugs.gnu.org; 2 Aug 2018 14:05:33 +0000 Original-Received: from localhost ([127.0.0.1]:39074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flEEP-00033y-DH for submit@debbugs.gnu.org; Thu, 02 Aug 2018 10:05:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flEEN-00033k-DV for 32194@debbugs.gnu.org; Thu, 02 Aug 2018 10:05:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flEED-0005BR-K0 for 32194@debbugs.gnu.org; Thu, 02 Aug 2018 10:05:26 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flEED-0005B7-EG; Thu, 02 Aug 2018 10:05:21 -0400 Original-Received: from [176.228.60.248] (port=4721 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1flEEC-0000Ll-Ut; Thu, 02 Aug 2018 10:05:21 -0400 In-reply-to: <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> (message from Paul Eggert on Tue, 31 Jul 2018 11:21:38 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149206 Archived-At: > From: Paul Eggert > Cc: 32194@debbugs.gnu.org > Date: Tue, 31 Jul 2018 11:21:38 -0700 I've not yet read the patch, will do soon. But one aspect puzzles me: > > 2. Do we really need to rename src/regex.c? We could have 2 regex.c in > > separate directories, couldn't we? If possible, I'd prefer not to > > rename files, as that makes VCS forensics more complicated. > > Renaming src/regex.h works around problems with having two include files > src/regex.h and lib/regex.h that fight each other. I tried not renaming > src/regex.h at first, and then ran into problems and gave up; although I > surely could get it to work eventually, I figured that we'd continue to > have ongoing problems and so it would be better to bite the bullet. I'm definitely missing something here, because I don't understand why would these headers "fight" each other. I thought that using #include "regex.h" in src/regex.c should avoid any such "fights". But since you no doubt know about this feature, I wonder what did I miss that would prevent that from working in this case. Thanks.