From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34019: 26.1; Changing ispell-program-name causes unwanted behavior Date: Sat, 12 Jan 2019 13:28:33 +0200 Message-ID: <83lg3qf732.fsf@gnu.org> References: <87bm4q8zsh.fsf@bulbul> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1547292489 28019 195.159.176.226 (12 Jan 2019 11:28:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2019 11:28:09 +0000 (UTC) Cc: 34019-done@debbugs.gnu.org To: philip@warpmail.net (Philip K.) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 12 12:28:01 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHSL-00076D-Ev for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 12:28:01 +0100 Original-Received: from localhost ([127.0.0.1]:50452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHUS-0008PX-Hu for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 06:30:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHUK-0008PL-Fx for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:30:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giHUJ-0000Hf-Ov for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giHUJ-0000HV-Ky for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giHUJ-0003GV-8C for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:30:03 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jan 2019 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 34019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 34019@debbugs.gnu.org, eliz@gnu.org, philip@warpmail.net Original-Received: via spool by 34019-done@debbugs.gnu.org id=D34019.154729254112425 (code D ref 34019); Sat, 12 Jan 2019 11:30:02 +0000 Original-Received: (at 34019-done) by debbugs.gnu.org; 12 Jan 2019 11:29:01 +0000 Original-Received: from localhost ([127.0.0.1]:56566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHTJ-0003EF-8o for submit@debbugs.gnu.org; Sat, 12 Jan 2019 06:29:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHTG-0003E0-Rl for 34019-done@debbugs.gnu.org; Sat, 12 Jan 2019 06:28:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHTB-00081z-G9; Sat, 12 Jan 2019 06:28:53 -0500 Original-Received: from [176.228.60.248] (port=1248 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1giHTB-0002rv-3T; Sat, 12 Jan 2019 06:28:53 -0500 In-reply-to: <87bm4q8zsh.fsf@bulbul> (philip@warpmail.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154373 Archived-At: > From: philip@warpmail.net (Philip K.) > Date: Wed, 09 Jan 2019 01:01:18 +0100 > > I've recently updated my Debian installation from stretch (9, stable) to > buster (10, testing) and I got to install Emacs 26.1 + enchant. But > sadly the version in the Debian repository is still too old (1.6 vs > 2.1). But when changing back to aspell, I was informed that aspell was > too old (0.6 vs 2.1). > > It's easy to reproduce the bug, assuming one's enchant is also too > old. Simply eval > > (setq-default ispell-program-name (executable-find "enchant")) > > try spell-checking any word (which should lead to an error), followed by > > (setq-default ispell-program-name (executable-find "aspell")) > > or whatever one was using before. Any spell-checking should still not > work, and an error will be reported no matter what version of > aspell/hunspell/ispell one uses. > > Looking through the code I noticed that the issue was simply caused by > forgetting to reset the variable `ispell-really-enchant`, thus resetting > it fixes the issue. Thanks, pushed to the emacs-26 branch, and will appear in Emacs 26.2. > I hope I haven't messed something up in the process, since this is the > first time I'm sending a patch. If that's not the case, please tell me > and I'll be eager to fix any issue (related to this bug). The commit log message should state the function in which the change was made. See the commit I actually made. Otherwise, the patch was OK, but for some reason it "git am" didn't apply it; perhaps because you seem to have customized the number of context lines?