From: Eli Zaretskii <eliz@gnu.org>
To: philip@warpmail.net (Philip K.)
Cc: 34019-done@debbugs.gnu.org
Subject: bug#34019: 26.1; Changing ispell-program-name causes unwanted behavior
Date: Sat, 12 Jan 2019 13:28:33 +0200 [thread overview]
Message-ID: <83lg3qf732.fsf@gnu.org> (raw)
In-Reply-To: <87bm4q8zsh.fsf@bulbul> (philip@warpmail.net)
> From: philip@warpmail.net (Philip K.)
> Date: Wed, 09 Jan 2019 01:01:18 +0100
>
> I've recently updated my Debian installation from stretch (9, stable) to
> buster (10, testing) and I got to install Emacs 26.1 + enchant. But
> sadly the version in the Debian repository is still too old (1.6 vs
> 2.1). But when changing back to aspell, I was informed that aspell was
> too old (0.6 vs 2.1).
>
> It's easy to reproduce the bug, assuming one's enchant is also too
> old. Simply eval
>
> (setq-default ispell-program-name (executable-find "enchant"))
>
> try spell-checking any word (which should lead to an error), followed by
>
> (setq-default ispell-program-name (executable-find "aspell"))
>
> or whatever one was using before. Any spell-checking should still not
> work, and an error will be reported no matter what version of
> aspell/hunspell/ispell one uses.
>
> Looking through the code I noticed that the issue was simply caused by
> forgetting to reset the variable `ispell-really-enchant`, thus resetting
> it fixes the issue.
Thanks, pushed to the emacs-26 branch, and will appear in Emacs 26.2.
> I hope I haven't messed something up in the process, since this is the
> first time I'm sending a patch. If that's not the case, please tell me
> and I'll be eager to fix any issue (related to this bug).
The commit log message should state the function in which the change
was made. See the commit I actually made. Otherwise, the patch was
OK, but for some reason it "git am" didn't apply it; perhaps because
you seem to have customized the number of context lines?
prev parent reply other threads:[~2019-01-12 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 0:01 bug#34019: 26.1; Changing ispell-program-name causes unwanted behavior Philip K.
2019-01-12 11:28 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lg3qf732.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34019-done@debbugs.gnu.org \
--cc=philip@warpmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).