From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Thu, 25 Apr 2019 13:44:10 +0300 Message-ID: <83lfzyz7np.fsf@gnu.org> References: <87sh806xwa.fsf@chapu.is> <83a7gjaen6.fsf@gnu.org> <83ftqa8qsg.fsf@gnu.org> <83muki6y6r.fsf@gnu.org> <4b8c6799-e845-768b-749c-f2a883ab89f8@yandex.ru> <83h8aq6v6a.fsf@gnu.org> <834l6q6ozn.fsf@gnu.org> <83zhoi59ao.fsf@gnu.org> <83wojm57sl.fsf@gnu.org> <83ftq96azk.fsf@gnu.org> <83wojk534g.fsf@gnu.org> <6308ceff-479b-2ce7-2072-41e683978c7c@yandex.ru> <83h8ao4vl0.fsf@gnu.org> <835zr32x2m.fsf@gnu.org> <8f3318e9-25bd-c7af-20dd-ed78d2a92efd@yandex.ru> <831s1r2uzx.fsf@gnu.org> <83wojj1ep8.fsf@gnu.org> <429a19a3-52aa-02d1-0bd0-77c27c6811d7@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250933"; mail-complaints-to="usenet@blaine.gmane.org" Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 25 12:52:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJbz2-0013A8-2Y for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 12:52:04 +0200 Original-Received: from localhost ([127.0.0.1]:55158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbz0-0003Ux-U5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 06:52:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbyq-0003TV-LS for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 06:51:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJbsE-0003jN-GM for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 06:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44046) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJbsE-0003jA-DL for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 06:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJbsE-0005W4-0v for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 06:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.155618907821157 (code B ref 31138); Thu, 25 Apr 2019 10:45:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 25 Apr 2019 10:44:38 +0000 Original-Received: from localhost ([127.0.0.1]:57590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJbrp-0005VA-Vp for submit@debbugs.gnu.org; Thu, 25 Apr 2019 06:44:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJbro-0005Uw-8V for 31138@debbugs.gnu.org; Thu, 25 Apr 2019 06:44:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbri-0002qM-Sl; Thu, 25 Apr 2019 06:44:30 -0400 Original-Received: from [176.228.60.248] (port=2417 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hJbri-0004tC-9X; Thu, 25 Apr 2019 06:44:30 -0400 In-reply-to: <429a19a3-52aa-02d1-0bd0-77c27c6811d7@yandex.ru> (message from Dmitry Gutov on Wed, 24 Apr 2019 23:25:32 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158244 Archived-At: > Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 24 Apr 2019 23:25:32 +0300 > > >> Relying on the library is probably faster. > > > > Why faster? > > Because the library will perform its validation anyway, during normal > execution. But if we validate the string before even calling the library, that will be even faster, no? > Any extra validation work Emacs performs, will take time on > top of that (of course, I don't know how much time). Didn't we just establish that it's almost negligible? Especially for short strings? > > And more importantly, will the error indication be useful enough to > > the Lisp program that triggered it? If we signal an error, we can > > make sure of that. > > We still signal errors if the library returns an error code. But we need to guess the reason. > Anyway, speeding up encoding is not as important as it was with > decoding, because at least in this case Lisp programs can control how > much data is sent. So let's not spend too much time and effort on it. OK.