From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36447: 27.0.50; New "Unknown keyword" errors Date: Fri, 05 Jul 2019 21:07:03 +0300 Message-ID: <83lfxc9wzc.fsf@gnu.org> References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> <83pnmoacft.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="56762"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael_heerdegen@web.de, npostavs@gmail.com, pipcet@gmail.com, 36447@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 20:08:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjScz-000EeZ-9J for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 20:08:09 +0200 Original-Received: from localhost ([::1]:55240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjScy-0008Qg-Aw for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 14:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37302) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjSct-0008QV-AE for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 14:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjScs-0004WQ-Ck for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 14:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjScs-0004WG-93 for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 14:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjScs-0002KH-1p for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 14:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36447 X-GNU-PR-Package: emacs Original-Received: via spool by 36447-submit@debbugs.gnu.org id=B36447.15623500388875 (code B ref 36447); Fri, 05 Jul 2019 18:08:02 +0000 Original-Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 18:07:18 +0000 Original-Received: from localhost ([127.0.0.1]:53702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjScA-0002J5-8K for submit@debbugs.gnu.org; Fri, 05 Jul 2019 14:07:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjSc8-0002Ir-Al for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 14:07:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjSc2-00044Q-SB; Fri, 05 Jul 2019 14:07:10 -0400 Original-Received: from [176.228.60.248] (port=1956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjSc1-0007sM-SL; Fri, 05 Jul 2019 14:07:10 -0400 In-reply-to: (message from Stefan Monnier on Fri, 05 Jul 2019 14:00:22 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162143 Archived-At: > From: Stefan Monnier > Cc: Pip Cet , michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > Date: Fri, 05 Jul 2019 14:00:22 -0400 > > The problem is not rehashing in general, but rehashing a purecopied > hash-table. This should normally never be needed, since a purecopied > hash-table should never be modified (no puthash/remhash should be > applied to it), but sadly pdumper may need to recompute the hashes > because objects's addresses may have changed between the dump and > the reload. Then perhaps pdumper should make a new object when it does that? > His patch can/should be made slightly more efficient by only doing the > Fcopy_sequence on those hash-tables that are in purespace. I cannot say I like tweaking the GP implementation for the benefit of what only the pdumper must do, it doesn't feel right. Problems caused by the pdumper should IMO be fixed in pdumper code.