From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: ofv@wanadoo.es, 36834@debbugs.gnu.org
Subject: bug#36834: 27.0.50; [PATCH] password-cache.el: confuses key absence with nil password
Date: Sat, 10 Aug 2019 13:01:18 +0300 [thread overview]
Message-ID: <83lfw18hld.fsf@gnu.org> (raw)
In-Reply-To: <jwvpnldbd46.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 10 Aug 2019 05:14:22 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 10 Aug 2019 05:14:22 -0400
> Cc: 36834@debbugs.gnu.org
>
> > So I propose this patch:
> >
> > diff --git a/lisp/password-cache.el b/lisp/password-cache.el
> > index 5a09ae4859..6009fb491e 100644
> > --- a/lisp/password-cache.el
> > +++ b/lisp/password-cache.el
> > @@ -81,7 +81,8 @@ password-in-cache-p
> > "Check if KEY is in the cache."
> > (and password-cache
> > key
> > - (gethash key password-data)))
> > + (not (eq (gethash key password-data 'password-cache-no-data)
> > + 'password-cache-no-data))))
> >
> > (defun password-read (prompt &optional key)
> > "Read password, for use with KEY, from user, or from cache if wanted.
> > @@ -125,7 +126,9 @@ password-cache-remove
> > (defun password-cache-add (key password)
> > "Add password to cache.
> > The password is removed by a timer after `password-cache-expiry' seconds."
> > - (when (and password-cache-expiry (null (gethash key password-data)))
> > + (when (and password-cache-expiry
> > + (eq (gethash key password-data 'password-cache-no-data)
> > + 'password-cache-no-data))
> > (run-at-time password-cache-expiry nil
> > #'password-cache-remove
> > key))
>
> Looks good to me, thanks.
Thanks.
Óscar, please push to the emacs-26 branch, and thanks.
next prev parent reply other threads:[~2019-08-10 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 5:12 bug#36834: 27.0.50; [PATCH] password-cache.el: confuses key absence with nil password Óscar Fuentes
2019-07-29 8:36 ` Basil L. Contovounesios
2019-07-29 14:12 ` Óscar Fuentes
2019-08-10 8:19 ` Eli Zaretskii
2019-08-11 16:00 ` Basil L. Contovounesios
2019-08-10 9:14 ` Stefan Monnier
2019-08-10 10:01 ` Eli Zaretskii [this message]
2019-08-11 23:45 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lfw18hld.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36834@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).