From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37856: 27.0.50; 'next-error' advised with 'recenter' signals error when run from "*grep*" buffer Date: Mon, 21 Oct 2019 22:30:42 +0300 Message-ID: <83lftd28wt.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117747"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37856@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 21:31:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMdOa-000UTT-0z for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 21:31:12 +0200 Original-Received: from localhost ([::1]:47234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMdOY-0002PQ-Pp for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 15:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33469) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMdOS-0002PJ-Qn for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 15:31:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMdOQ-0004zX-Sa for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 15:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49034) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMdOQ-0004zK-9Q for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 15:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMdOQ-000393-4n for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37856 X-GNU-PR-Package: emacs Original-Received: via spool by 37856-submit@debbugs.gnu.org id=B37856.157168625612077 (code B ref 37856); Mon, 21 Oct 2019 19:31:02 +0000 Original-Received: (at 37856) by debbugs.gnu.org; 21 Oct 2019 19:30:56 +0000 Original-Received: from localhost ([127.0.0.1]:57855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMdOK-00038i-Fw for submit@debbugs.gnu.org; Mon, 21 Oct 2019 15:30:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMdOJ-00038V-1W for 37856@debbugs.gnu.org; Mon, 21 Oct 2019 15:30:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMdOD-0004v9-JQ; Mon, 21 Oct 2019 15:30:49 -0400 Original-Received: from [176.228.60.248] (port=3995 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMdOC-0000sJ-Q4; Mon, 21 Oct 2019 15:30:49 -0400 In-reply-to: (message from Stefan Kangas on Mon, 21 Oct 2019 20:38:47 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169940 Archived-At: > From: Stefan Kangas > Date: Mon, 21 Oct 2019 20:38:47 +0200 > > 1. Under "emacs -Q", evaluate: > (defun my-advice (&rest args) > (recenter)) > (advice-add 'next-error :after #'my-advice) > 2. M-x rgrep RET [... grep for something] > 3. Run 'next-error' (M-g M-n) from the "*grep*" buffer. > > Result: I get the error: > recenter-top-bottom: ‘recenter’ing a window that does not display > current-buffer. Why isn't this a cockpit error: you force a function that happens to switch buffers to recenter. It's like you've added a call to 'recenter' in some arbitrary place in a random function: you are responsible for that code, and if it does stuff that it shouldn't, your code is wrong. No? > This seems to be due to this code in window.c: > > /* For reasons why we signal an error here, see > https://lists.gnu.org/r/emacs-devel/2014-06/msg00053.html, > https://lists.gnu.org/r/emacs-devel/2014-06/msg00094.html. */ > if (buf != current_buffer) > error ("`recenter'ing a window that does not display current-buffer."); Yes, and that's on purpose, see the cited discussion.