unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36950: 27.0.50; Paste to isearch does not work
@ 2019-08-06 22:12 Juri Linkov
  2019-12-12 23:58 ` Juri Linkov
  0 siblings, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2019-08-06 22:12 UTC (permalink / raw)
  To: 36950

This is continuation of the closed bug#18727.
The xterm paste facility needs to be rewritten
to be like the GUI paste, so pasting to isearch
doesn't hang.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36950: 27.0.50; Paste to isearch does not work
  2019-08-06 22:12 bug#36950: 27.0.50; Paste to isearch does not work Juri Linkov
@ 2019-12-12 23:58 ` Juri Linkov
  2019-12-13  7:27   ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2019-12-12 23:58 UTC (permalink / raw)
  To: 36950

> This is continuation of the closed bug#18727.

This needs to be fixed before the release.  I provided the following patch
that fixes the problem, and don't know what else is needed.

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 7c22e6ad97..1705b050b5 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2508,10 +2508,12 @@ isearch-mouse-2
 
 (declare-function xterm--pasted-text "term/xterm" ())
 
-(defun isearch-xterm-paste ()
+(defun isearch-xterm-paste (event)
   "Pull terminal paste into search string."
-  (interactive)
-  (isearch-yank-string (xterm--pasted-text)))
+  (interactive "e")
+  (when (eq (car-safe event) 'xterm-paste)
+    (let ((pasted-text (nth 1 event)))
+      (isearch-yank-string pasted-text))))
 
 (defun isearch-yank-internal (jumpform)
   "Pull the text from point to the point reached by JUMPFORM.





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#36950: 27.0.50; Paste to isearch does not work
  2019-12-12 23:58 ` Juri Linkov
@ 2019-12-13  7:27   ` Eli Zaretskii
  2019-12-14 23:18     ` Juri Linkov
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2019-12-13  7:27 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 36950

> From: Juri Linkov <juri@linkov.net>
> Date: Fri, 13 Dec 2019 01:58:30 +0200
> 
> > This is continuation of the closed bug#18727.
> 
> This needs to be fixed before the release.  I provided the following patch
> that fixes the problem, and don't know what else is needed.

You said there that this is somewhat ugly, and that a different
implementation would be cleaner.  Can you please elaborate?





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36950: 27.0.50; Paste to isearch does not work
  2019-12-13  7:27   ` Eli Zaretskii
@ 2019-12-14 23:18     ` Juri Linkov
  2019-12-15 15:27       ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2019-12-14 23:18 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 36950

>> > This is continuation of the closed bug#18727.
>> 
>> This needs to be fixed before the release.  I provided the following patch
>> that fixes the problem, and don't know what else is needed.
>
> You said there that this is somewhat ugly, and that a different
> implementation would be cleaner.  Can you please elaborate?

Those are your words, not mine.  In bug#18727 you said:

  That's somewhat ugly, IMO.  We should try making the xterm paste
  facility play by the rules, like the GUI paste functionality does.

I don't know what you meant.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36950: 27.0.50; Paste to isearch does not work
  2019-12-14 23:18     ` Juri Linkov
@ 2019-12-15 15:27       ` Eli Zaretskii
  2019-12-16  0:19         ` Juri Linkov
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2019-12-15 15:27 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 36950

> From: Juri Linkov <juri@linkov.net>
> Cc: 36950@debbugs.gnu.org
> Date: Sun, 15 Dec 2019 01:18:05 +0200
> 
> >> > This is continuation of the closed bug#18727.
> >> 
> >> This needs to be fixed before the release.  I provided the following patch
> >> that fixes the problem, and don't know what else is needed.
> >
> > You said there that this is somewhat ugly, and that a different
> > implementation would be cleaner.  Can you please elaborate?
> 
> Those are your words, not mine.

Oops, you are right, sorry.

So please go ahead and install this.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36950: 27.0.50; Paste to isearch does not work
  2019-12-15 15:27       ` Eli Zaretskii
@ 2019-12-16  0:19         ` Juri Linkov
  0 siblings, 0 replies; 6+ messages in thread
From: Juri Linkov @ 2019-12-16  0:19 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 36950

tags 36950 fixed
close 36950 27.0.50
quit

>> >> > This is continuation of the closed bug#18727.
>> >>
>> >> This needs to be fixed before the release.  I provided the following patch
>> >> that fixes the problem, and don't know what else is needed.
>> >
>> > You said there that this is somewhat ugly, and that a different
>> > implementation would be cleaner.  Can you please elaborate?
>>
>> Those are your words, not mine.
>
> Oops, you are right, sorry.
>
> So please go ahead and install this.

Done.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-16  0:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 22:12 bug#36950: 27.0.50; Paste to isearch does not work Juri Linkov
2019-12-12 23:58 ` Juri Linkov
2019-12-13  7:27   ` Eli Zaretskii
2019-12-14 23:18     ` Juri Linkov
2019-12-15 15:27       ` Eli Zaretskii
2019-12-16  0:19         ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).