From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 08:39:45 +0300 Message-ID: <83lfh50zxa.fsf@gnu.org> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19153"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 07:40:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJs59-0004s1-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 07:40:15 +0200 Original-Received: from localhost ([::1]:35522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJs58-0007Ti-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 01:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJs4w-0007Ta-HH for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 01:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJs4w-0004Mn-7P for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 01:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJs4w-00057X-41 for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 01:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 05:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160058039519667 (code B ref 6227); Sun, 20 Sep 2020 05:40:02 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 05:39:55 +0000 Original-Received: from localhost ([127.0.0.1]:48563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJs4p-000579-5z for submit@debbugs.gnu.org; Sun, 20 Sep 2020 01:39:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJs4n-00056w-NC for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 01:39:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58984) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJs4h-0004Ld-6v; Sun, 20 Sep 2020 01:39:47 -0400 Original-Received: from [176.228.60.248] (port=2408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJs4g-0006it-NQ; Sun, 20 Sep 2020 01:39:47 -0400 In-Reply-To: <87mu1llak3.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 19 Sep 2020 23:29:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188456 Archived-At: > From: Lars Ingebrigtsen > Date: Sat, 19 Sep 2020 23:29:48 +0200 > Cc: Lennart Borgman , 6227@debbugs.gnu.org > > I think the results are really nice. I guess we should add a few more > faces before applying? > > Anybody else got any comments on this? Comment #1: Do we really want to turn this feature on by default? > +(defface isearch-1 > + '((((class color) (min-colors 88) (background light)) > + :background "magenta2" :foreground "lightskyblue1") > + (((class color) (min-colors 88) (background dark)) > + :background "palevioletred3" :foreground "brown4")) > + "Used for displaying the first matching subexpression.") > + > +(defface isearch-2 > + '((((class color) (min-colors 88) (background light)) > + :background "magenta1" :foreground "lightskyblue1") > + (((class color) (min-colors 88) (background dark)) > + :background "palevioletred4" :foreground "brown4")) > + "Used for displaying the second matching subexpression.") Comment #2: This seems to effectively disable the feature on displays that have fewer than 88 colors. Is that intentional? If so, why doesn't the documentation say so? Comment #3: What about NEWS and the manual? Thanks.