From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44236: [PATCH] xdisp: Apply nobreak-char-display also to NARROW NO-BREAK SPACE U+202F Date: Sun, 01 Nov 2020 21:59:26 +0200 Message-ID: <83lffketlt.fsf@gnu.org> References: <20201026111348.773761-1-bpeeluk.ref@yahoo.co.uk> <20201026111348.773761-1-bpeeluk@yahoo.co.uk> <837drdeyss.fsf@gnu.org> <87h7q98p4q.fsf@mail.linkov.net> <87imapcjam.fsf@gnus.org> <87wnz4zz5k.fsf@mail.linkov.net> <83wnz4euxk.fsf@gnu.org> <87r1pcyib0.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21138"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bpeeluk@yahoo.co.uk, larsi@gnus.org, 44236@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 21:00:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZJWg-0005Q4-I2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 21:00:30 +0100 Original-Received: from localhost ([::1]:54308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZJWf-00076p-Jr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 15:00:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZJWE-00076S-Pv for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 15:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZJWE-0006Ks-CA for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 15:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZJWE-0002Sg-96 for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 15:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 44236-submit@debbugs.gnu.org id=B44236.16042607899418 (code B ref 44236); Sun, 01 Nov 2020 20:00:02 +0000 Original-Received: (at 44236) by debbugs.gnu.org; 1 Nov 2020 19:59:49 +0000 Original-Received: from localhost ([127.0.0.1]:38647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZJW0-0002Rq-KQ for submit@debbugs.gnu.org; Sun, 01 Nov 2020 14:59:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZJVy-0002Re-Rc for 44236@debbugs.gnu.org; Sun, 01 Nov 2020 14:59:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60070) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZJVs-0006H2-4x; Sun, 01 Nov 2020 14:59:40 -0500 Original-Received: from [176.228.60.248] (port=4428 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZJVr-0003ZU-HG; Sun, 01 Nov 2020 14:59:39 -0500 In-Reply-To: <87r1pcyib0.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 01 Nov 2020 21:41:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192458 Archived-At: > From: Juri Linkov > Cc: larsi@gnus.org, bpeeluk@yahoo.co.uk, 44236@debbugs.gnu.org > Date: Sun, 01 Nov 2020 21:41:10 +0200 > > >> Maybe highlighting should check for some text properties, > >> and not to highlight nobreak-chars in text with these properties? > > > > That would mean an entirely different implementation from what we have > > now. > > get_next_display_element has no access to text properties? Text properties are handled by the display code on a level above get_next_display_element. But that's not what I meant. I meant that if we want to base this on text properties, we should do this via hi-lock or similar, not in the display engine which treats all characters the same. Alternatively, if this new feature is so annoying, and people are unwilling to customize their Emacs to get the old behavior back, maybe we should make nobreak-char-display more than just a simple boolean, so that people could control which characters are and aren't emphasized?