From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Tue, 04 May 2021 14:34:45 +0300 Message-ID: <83lf8u68bu.fsf@gnu.org> References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 04 13:36:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldtLU-0006MP-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 13:36:08 +0200 Original-Received: from localhost ([::1]:55120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldtLT-00044W-Pu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 07:36:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldtLO-00043v-5M for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 07:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldtLN-0006gB-Tu for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 07:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldtLN-0004YJ-Qw for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 07:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 11:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162012812417491 (code B ref 48137); Tue, 04 May 2021 11:36:01 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 4 May 2021 11:35:24 +0000 Original-Received: from localhost ([127.0.0.1]:52683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldtKm-0004Y3-0R for submit@debbugs.gnu.org; Tue, 04 May 2021 07:35:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldtKk-0004Xx-0S for 48137@debbugs.gnu.org; Tue, 04 May 2021 07:35:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49540) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldtKe-00069p-BT; Tue, 04 May 2021 07:35:16 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3789 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ldtKN-0002q8-VF; Tue, 04 May 2021 07:35:01 -0400 In-Reply-To: (message from Stefan Monnier on Mon, 03 May 2021 15:41:47 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205596 Archived-At: > From: Stefan Monnier > Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org > Date: Mon, 03 May 2021 15:41:47 -0400 > > > I think it's wrong for package.el to try to decode these files. It > > should deliver the files to the disk exactly as they are received > > through the wire. And the only safe way of doing that is to treat > > these files as raw bytes. > > I'm not sure what you're referring to here. To the suggestion to decode *.el files by package.el as part of the installation. > In the OP's case, i.e. `package-install-file` (which is a seldom used > functionality, not part of the "normal" `package-install`) the file doesn't go > through the wire: it's already "local" and we currently implement this > code on top of `package-install-from-buffer`, so it has to work > correctly with an already-decoded buffer. If this works with buffer text, then how are DOS EOLs come into play here? There are no CRLF pairs in decoded buffer text.