From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48901: [kisara.moe] Re: [kisara.moe] Re: [kisara.moe] Re: [kisara.moe] Re: bug#48901: [kisara.moe] 28.0.50; Support text-based fringe contents alongside bitmaps Date: Mon, 05 Jul 2021 14:43:40 +0300 Message-ID: <83lf6lgf4j.fsf@gnu.org> References: <875yyp7qfk.fsf@kisara.moe> <83y2blg59g.fsf@gnu.org> <877diulqxy.fsf@kisara.moe> <83tulx26rf.fsf@gnu.org> <875yxpla3r.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5414"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48901@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 05 13:44:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0N1P-0001BH-EZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jul 2021 13:44:19 +0200 Original-Received: from localhost ([::1]:47646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0N1N-0007tD-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jul 2021 07:44:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0N18-0007t5-Q4 for bug-gnu-emacs@gnu.org; Mon, 05 Jul 2021 07:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0N18-00016W-Bl for bug-gnu-emacs@gnu.org; Mon, 05 Jul 2021 07:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0N18-0005O6-7B for bug-gnu-emacs@gnu.org; Mon, 05 Jul 2021 07:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jul 2021 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48901 X-GNU-PR-Package: emacs Original-Received: via spool by 48901-submit@debbugs.gnu.org id=B48901.162548543720692 (code B ref 48901); Mon, 05 Jul 2021 11:44:02 +0000 Original-Received: (at 48901) by debbugs.gnu.org; 5 Jul 2021 11:43:57 +0000 Original-Received: from localhost ([127.0.0.1]:44283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0N0z-0005Na-GH for submit@debbugs.gnu.org; Mon, 05 Jul 2021 07:43:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0N0t-0005ND-Qy for 48901@debbugs.gnu.org; Mon, 05 Jul 2021 07:43:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33578) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0N0h-0000t4-OW; Mon, 05 Jul 2021 07:43:36 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3981 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0N0h-0005TM-GG; Mon, 05 Jul 2021 07:43:35 -0400 In-Reply-To: <875yxpla3r.fsf@kisara.moe> (message from Mohsin Kaleem on Mon, 05 Jul 2021 04:20:56 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209447 Archived-At: [Please always use Reply All to keep the bug address on the CC list.] > From: Mohsin Kaleem > Date: Mon, 05 Jul 2021 04:20:56 +0100 > > Eli Zaretskii writes: > > >> From: Mohsin Kaleem > >> Cc: 48901@debbugs.gnu.org > >> Date: Tue, 15 Jun 2021 23:10:33 +0100 > >> > >> What are your thoughts on having a dedicated face for the margin? > > > > Lisp programs display in the margins by putting string-valued > > properties on buffer text. While doing that, how hard is it to > > specify the face for those strings? it's just one call to 'propertize' > > away. > > > > By default, the text displayed in the margins inherits the face of the > > text on which you put the corresponding properties, right? Why isn't > > that a good default? > > I understand that but I still think there should be a built-in face that > these other margin faces can inherit from. > At the moment for example `diff-hl-mode` uses `diff-hl-margin-change`, > and several other faces for the margin indicators. I've set these up to > inherit from my `fringe` face so where diff-hl-mode attaches a margin > indicator it looks like its on the fringe. However where it doesn't no > default margin face exists so diff-hl-mode just applies the `default` > face which looks out of place alongside margin faces. > Now of course I could send a PR over to diff-hl-mode to ask them to let > me specify a face for sections that don't have anything diff-hl needs to > highlight, but then I'd have to do the same for every other package that > does something like this for the margin; admittedly I only know of 2 > such packages atm so it's manageable, however a built in default face to > inherit from seems to me like the best way to do this. What you ask for might not be easy to implement. AFAIR, Emacs determines the face of the characters before it knows where they will be displayed. Since the text on the margins is displayed using text or overlay properties similar to other uses of these properties, by the time Emacs knowns some text needs to be displayed on the margin it's too late: the face has been already merged.