From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 50376@debbugs.gnu.org
Subject: bug#50376: 28.0.50; Counsel M-x completion segfaults in command-modes
Date: Sat, 04 Sep 2021 20:42:41 +0300 [thread overview]
Message-ID: <83lf4cutim.fsf@gnu.org> (raw)
In-Reply-To: <87wnnww94f.fsf@tcd.ie> (bug-gnu-emacs@gnu.org)
> Date: Sat, 04 Sep 2021 18:20:16 +0100
> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> * src/data.c (Fcommand_modes): Check that bytecode object is
> interactive before accessing its interactive spec to avoid
> segfaulting.
> ---
> src/data.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/data.c b/src/data.c
> index ffca7e7535..27b642df28 100644
> --- a/src/data.c
> +++ b/src/data.c
> @@ -1045,6 +1045,8 @@ DEFUN ("command-modes", Fcommand_modes, Scommand_modes, 1, 1, 0,
>
> if (COMPILEDP (fun))
> {
> + if (PVSIZE (fun) <= COMPILED_INTERACTIVE)
> + return Qnil;
> Lisp_Object form = AREF (fun, COMPILED_INTERACTIVE);
> if (VECTORP (form))
> /* New form -- the second element is the command modes. */
LGTM, thanks.
next prev parent reply other threads:[~2021-09-04 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 17:20 bug#50376: 28.0.50; Counsel M-x completion segfaults in command-modes Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-04 17:42 ` Eli Zaretskii [this message]
2021-09-04 19:31 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf4cutim.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50376@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).