From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 50599@debbugs.gnu.org
Subject: bug#50599: [PATCH] Don't recommend against "\[...]" substitutions for performance
Date: Wed, 15 Sep 2021 18:41:27 +0300 [thread overview]
Message-ID: <83lf3xc0d4.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmn84oZCWfXY-w_1qiv2gCq_woGQbGc8Jb=Nwq5W9pkXrQ@mail.gmail.com> (message from Stefan Kangas on Wed, 15 Sep 2021 16:13:59 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 15 Sep 2021 16:13:59 +0200
> Cc: 50599@debbugs.gnu.org
>
> We change, in my patch, 'checkdoc-max-keyref-before-warn' to a value
> like 1000 or 500 instead of nil. This would make me happy by not
> impacting any real use-cases [none of which will have 500+ commands in
> its docstring, or at least none of the ones that I care about will]
> and it would (hopefully) make you happy by sufficiently calling
> attention to any possible performance issues in some other cases.
I didn't realize that checkdoc is involved in this. If the problem is
that it produces annoying diagnostics for \\[..], then I'm okay with
removing it or making it less frequent.
I was only talking about the manual.
> With that, perhaps we could agree that it is okay to delete the
> paragraph in `(elisp) Documentation Tips'. Running 'checkdoc' is
> after all recommended in that section as well. WDYT?
My reluctance to delete that advice is unrelated to checkdoc or what
it does. I don't want to remove that advice completely, as I already
said and explained. But I'm okay with making the text be a more
general advice as opposed to some rigid rule.
next prev parent reply other threads:[~2021-09-15 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:27 bug#50599: [PATCH] Don't recommend against "\[...]" substitutions for performance Stefan Kangas
2021-09-15 6:38 ` Eli Zaretskii
2021-09-15 7:11 ` Stefan Kangas
2021-09-15 8:24 ` Eli Zaretskii
2021-09-15 14:13 ` Stefan Kangas
2021-09-15 15:41 ` Eli Zaretskii [this message]
2021-09-15 18:37 ` Stefan Kangas
2021-09-15 19:03 ` Eli Zaretskii
2021-09-16 14:08 ` Lars Ingebrigtsen
2021-09-15 15:46 ` bug#50599: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf3xc0d4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50599@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).