From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51523: 29.0.50; gnus-mime-view-part-externally very slow Date: Wed, 03 Nov 2021 15:06:32 +0200 Message-ID: <83lf25ie1z.fsf@gnu.org> References: <87v91dmcyz.fsf@gnus.org> <7b7f5641fcf9629c6074@heytings.org> <875ytcwxp7.fsf@gnus.org> <6abcac838b0dd46d94cf@heytings.org> <87sfwgvi73.fsf@gnus.org> <6abcac838bc0f53a0f78@heytings.org> <6abcac838bb83b0904d7@heytings.org> <6abcac838b7f89ee4e21@heytings.org> <831r3zncow.fsf@gnu.org> <6abcac838b521de77925@heytings.org> <83zgqnlt7t.fsf@gnu.org> <87y267revf.fsf@gnus.org> <83v91blrux.fsf@gnu.org> <87o873rdyx.fsf@gnus.org> <83r1bzlrkw.fsf@gnu.org> <87bl33rdrv.fsf@gnus.org> <83mtmnlr93.fsf@gnu.org> <87wnlrpyok.fsf@gnus.org> <6abcac838b9fc735488f@heytings.org> <83sfwek2wu.fsf@gnu.org> <11d5fecb444b249c7dd2@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51523@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 03 14:07:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miFyx-0002jl-F0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 14:07:11 +0100 Original-Received: from localhost ([::1]:58582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miFyv-0004EC-Eq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 09:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miFyp-0004Dy-4t for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 09:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miFyo-0007Hl-Oe for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 09:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miFyo-0008Lr-5d for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 09:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51523-submit@debbugs.gnu.org id=B51523.163594480332070 (code B ref 51523); Wed, 03 Nov 2021 13:07:02 +0000 Original-Received: (at 51523) by debbugs.gnu.org; 3 Nov 2021 13:06:43 +0000 Original-Received: from localhost ([127.0.0.1]:39462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miFyV-0008LB-05 for submit@debbugs.gnu.org; Wed, 03 Nov 2021 09:06:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miFyT-0008Ko-KE for 51523@debbugs.gnu.org; Wed, 03 Nov 2021 09:06:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miFyN-0007E0-4M; Wed, 03 Nov 2021 09:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Wgskpzfiv5AAapAWO0XaVBbggVmWH4XO+hSV6kOPMQU=; b=kaYpEuNNbYQM rEAuG3kzpcdzKz2FVvNK34vR1yE4ZE/zq/Wp3l9ayRgGmoBgdtgktSm6U1cPC4xNe83+2B1v3uu5t shLvna7rRHdz9JsNPrHWuIasyLKovZXFVp5/VX8qq9a93fumF09cSt4EmTWZ7vV1DdkE/FOFG7Ylx lP/j81wTnpcDRyQTKRM7mlwJukAWRNuEOm/eHmAJHAYl491YaAz93ZNtwvCI4N7b6+Q8wr5atyDh6 ejPvzn8iw1xGJO2hsll6avLX51VSDnesCVjpfzke7v2NFRxVGNXEeNxrFXNNEY/cs9+XRW6C1Cq/R Eu2yPE/qyxCP3DEboqyi3g==; Original-Received: from [87.69.77.57] (port=2856 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miFyM-0001yM-ML; Wed, 03 Nov 2021 09:06:34 -0400 In-Reply-To: <11d5fecb444b249c7dd2@heytings.org> (message from Gregory Heytings on Wed, 03 Nov 2021 10:45:35 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218866 Archived-At: > Date: Wed, 03 Nov 2021 10:45:35 +0000 > From: Gregory Heytings > cc: larsi@gnus.org, 51523@debbugs.gnu.org, monnier@iro.umontreal.ca > > >> I attach an improved version of file-has-changed-p. Following Eli's > >> suggestion, it records the file size together with its timestamp. > > > > What about expand-file-name or file-truename? That problem still exists > > in this new patch, AFAICT. > > I don't know what I should do here. Both Stefan and Lars think (IIUC) > that it's okay to use the filename as is. I tend to agree with them; > after all, the filename is only used as a key in the hash table, and > file-attributes finds the "right" file anyway. The function is buggy without that, so much so that I tend to remove it from Emacs. > Using expand-file-name or file-truename also makes that function much > slower: (benchmark-run 100000 (file-has-changed-p "~/.profile")) takes (on > my computer) 2 seconds in its current version, 3 seconds with > expand-file-name, and... 10 seconds with file-truename. This isn't a time critical function, so 0.1 msec per call is nothing to be afraid of.