From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Thu, 04 Nov 2021 10:11:08 +0200 Message-ID: <83lf24fihv.fsf@gnu.org> References: <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="922"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, stefan@marxist.se, kevin.legouguec@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 04 09:12:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miXr1-000Aaq-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Nov 2021 09:12:11 +0100 Original-Received: from localhost ([::1]:49942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miXqz-0007Pl-KP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Nov 2021 04:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miXqs-0007Pd-Rj for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 04:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miXqs-0005oM-Ix for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 04:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miXqs-0006Ry-D7 for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 04:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Nov 2021 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163601347724744 (code B ref 51556); Thu, 04 Nov 2021 08:12:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 4 Nov 2021 08:11:17 +0000 Original-Received: from localhost ([127.0.0.1]:41934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miXq9-0006R1-0b for submit@debbugs.gnu.org; Thu, 04 Nov 2021 04:11:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miXq7-0006Qo-9w for 51556@debbugs.gnu.org; Thu, 04 Nov 2021 04:11:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miXq0-0005QJ-NQ; Thu, 04 Nov 2021 04:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VtWkvxaFhIJruHkM9OLuIU8DKD9IPznnsm+UNK0Jn94=; b=Jtj6XnHFheXK N/fOpbyJatw335kAugbPiu29iEIL+vMmEwphzYzYTjGEayy0T7YyyAtLdNVg5wJ67FVLxF4HQTbXq s2tHg/kWHyajM8FiticWQQBpnbTn9Xxf4tHf3BWCEEqG7kelWKmXpgeKHYsu4Ke7Ng2tPvsaJS6zA 4JqBrluxXQOsxZAmstLMiBVaRJLz2Hlh1SlCm3v1GVmvHMCmAYPhd5d58LOEH7r8hpX1XNfjTQFxb xxlowpUpMectJ7SfSUSV1ZigFn5sW4PcHhA5B6FVYA2e8TJesUnAfy+VH5u6DU5I2tg19Re3W1osH DQh6cXagWGn4wQ+10GFOog==; Original-Received: from [87.69.77.57] (port=1852 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miXq0-0000N1-9X; Thu, 04 Nov 2021 04:11:08 -0400 In-Reply-To: (message from Alan Third on Tue, 2 Nov 2021 20:19:52 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218906 Archived-At: > Date: Tue, 2 Nov 2021 20:19:52 +0000 > From: Alan Third > Cc: Eli Zaretskii , Stefan Kangas , > 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > On Tue, Nov 02, 2021 at 11:43:58AM -0700, Jim Porter wrote: > > > > 1) Single-color SVGs > > > > Some SVGs are just a single-color shape, like the Customize arrows. There's > > no *particular* color that's right for these, aside from "what looks good". > > In some ways, these SVGs are like an ordinary textual glyph, except that > > we've defined our own fancy shape to use. In this case, I think it makes > > sense to be able to specify what color to use for the SVG independently of > > the shape so that themes can adjust it as-needed. > > > > This case is the one initially described in this bug. > > This is the case we looked at when we originally replaced the > customize widgets with SVGs. At the time we very intentionally removed > the colour and size information from the SVG files (checkbox.svg, etc) > so that they would match the colours and font size of the surrounding > text. > > I guess, unfortunately, these arrows were missed. Thanks. Since these SVG images were missed back then, I've changed my mind about the safety of the change, and cherry-picked the fix to the emacs-28 branch.