From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP Date: Sat, 06 Nov 2021 21:52:53 +0200 Message-ID: <83lf219i3u.fsf@gnu.org> References: <877ddv9ue0.fsf@jpl.nasa.gov> <87tugyptju.fsf@gnus.org> <87tugy8h3a.fsf@secretsauce.net> <87pmrl8yhy.fsf@secretsauce.net> <60fea707-a9b2-d9f4-cc45-ffd4539887b6@yandex.ru> <87o87253sv.fsf@secretsauce.net> <60af7952-d702-d40f-928e-1320e6d9520f@yandex.ru> <83f40a2a-ae5a-2c6c-cf6a-44ff7c933d16@yandex.ru> <831r3tb7un.fsf@gnu.org> <7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13579"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lists@dima.secretsauce.net, 51497@debbugs.gnu.org, larsi@gnus.org, wolfgang.scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 06 20:54:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjRlf-0003ME-0p for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 20:54:23 +0100 Original-Received: from localhost ([::1]:48614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjRld-00051P-KW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 15:54:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjRlM-00050X-9n for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 15:54:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjRlK-0003wy-H1 for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 15:54:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjRlK-0000z3-G1 for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 15:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Nov 2021 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51497-submit@debbugs.gnu.org id=B51497.16362284053735 (code B ref 51497); Sat, 06 Nov 2021 19:54:02 +0000 Original-Received: (at 51497) by debbugs.gnu.org; 6 Nov 2021 19:53:25 +0000 Original-Received: from localhost ([127.0.0.1]:50842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjRke-0000y8-Sq for submit@debbugs.gnu.org; Sat, 06 Nov 2021 15:53:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjRkd-0000xw-HH for 51497@debbugs.gnu.org; Sat, 06 Nov 2021 15:53:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjRkU-0003sQ-7N; Sat, 06 Nov 2021 15:53:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=URv1LGjx5WuP/2BdumLQyXCKCgRaEQcZuVZ5odWHvEM=; b=N4oswrrBJ0md GEd4FOz7cKFMgcjZrCxL9SNsg0otoUXF+AHIpfavliJk93GiqsR+nSJ/+Qp12rwwIvYM2mGlIRUvU WZ4kDAJVhQAYGJw1khWI1lFywhOSO7QR3HrdhITtM546PXdWr54d2auEsQ3t9zrIis4gWLZNYQjav LGoXzBZiC9GntOkeMA2YSjItyEt7x50NQRSLMSG+uR7oYneRIE39UNvoRhXb715ocnBl/G6mDbClL 0XfVJRsKueKPl7irvSgFg3OOpC46PqWIbMpPcg9PIuAK6NX+zEqCxmFjJBPdDFTPusdd54GhJb1/f DG3ibsAsSQCVZk7EGcsTyg==; Original-Received: from [87.69.77.57] (port=3035 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjRkS-0002mH-V6; Sat, 06 Nov 2021 15:53:10 -0400 In-Reply-To: <7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru> (message from Dmitry Gutov on Sat, 6 Nov 2021 22:44:55 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219158 Archived-At: > Cc: lists@dima.secretsauce.net, 51497@debbugs.gnu.org, larsi@gnus.org, > wolfgang.scherer@gmx.de > From: Dmitry Gutov > Date: Sat, 6 Nov 2021 22:44:55 +0300 > > > I'm a bit worried by the function relying on the fact that > > default-directory is the directory of the repository. Wouldn't it be > > better to explicitly let-bind it inside the function? > > We could, but notice how most of vc-git-* functions don't bind > default-directory, thus relying on its implicit value. It just how VC > works: expecting default-directory to have the right value around the calls. How certain are you that default-directory has the right value? Because if it doesn't, AFAIU all the connection-specific stuff will fall apart. > > A (perhaps safer) alternative for emacs-28 would be not to use > > :(literal) for remote repositories. What are the disadvantages of > > that? > > That would mean leaving bug#39452 unfixed on remote hosts. Only for files with wildcard characters in their names. How frequently does that happen? Also, it will be only unsolved in Emacs 28.