From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places Date: Thu, 11 Nov 2021 13:27:01 +0200 Message-ID: <83lf1v0w6y.fsf@gnu.org> References: <87fsxstdiy.fsf@miha-pc> <87czn79smi.fsf@gnus.org> <87mtmbgehx.fsf@miha-pc> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14088"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 48925@debbugs.gnu.org To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 12:30:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml8Hx-0003Uh-Bh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 12:30:41 +0100 Original-Received: from localhost ([::1]:48886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml8Hw-0005u2-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 06:30:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8FO-0002ul-GX for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 06:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml8FO-0005Le-6Q for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 06:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ml8FN-0006L5-RQ for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 06:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 11:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48925 X-GNU-PR-Package: emacs Original-Received: via spool by 48925-submit@debbugs.gnu.org id=B48925.163663004724297 (code B ref 48925); Thu, 11 Nov 2021 11:28:01 +0000 Original-Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 11:27:27 +0000 Original-Received: from localhost ([127.0.0.1]:40292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml8Eo-0006Jp-Ew for submit@debbugs.gnu.org; Thu, 11 Nov 2021 06:27:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml8EY-0006J9-Qc for 48925@debbugs.gnu.org; Thu, 11 Nov 2021 06:27:25 -0500 Original-Received: from [2001:470:142:3::e] (port=49738 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8ES-0005EX-WF; Thu, 11 Nov 2021 06:27:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6oH1lZbJ1zdPky2DRPKqeyPwVVd5/TmbufZMlkhe/2Q=; b=TVWytRmGQE7X A0fO5RtZLgovTEKtYE95L8Q9Wsa7XYlGrYrUBOxgdm99qhDQ9j9s7rSZWxCgixlDsZhepgt/9T1nK phzQnlOXDZvPhBQSwdFDeuNL84tvBiKBi/nq0j3yBoNHjVE8cy3B99ASx5SHiQM3+vCBsJpBPrOCO qGV22S9tzzXJoDk6WYdChrotK7A6nyCEgs5DT9t+gZ+ohFkrkBYsB0SPIVsTkB+790jttaXMI7pFM r0ln4HkKFRNWmTyMYvmqRR9rW0N0VNAmlPTwe9NXWhJsjSgbqd/fkRvUGZUl3Yml6v6T2CjpD32ef U3t3p1BalqcfnUUB1tUdYg==; Original-Received: from [87.69.77.57] (port=4456 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8ES-0007pa-JW; Thu, 11 Nov 2021 06:27:04 -0500 In-Reply-To: <87mtmbgehx.fsf@miha-pc> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219622 Archived-At: > Cc: 48925@debbugs.gnu.org > Date: Thu, 11 Nov 2021 11:42:34 +0100 > From: miha--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > >> To be on the safer side, I guess we could replace the > >> > >> specbind (Qminibuffer_completion_table, Qnil); > >> > >> with a use of `minibuffer-with-setup-hook` that sets the var to nil in > >> the new minibuffer. But doing it in C is awkward so it would best be > >> done by moving the function to subr.el. > > > > Sounds like a good idea to me. Miha, could you do that? > > Okay, patch attached. Moving read-string to subr.el means the function will be unavailable during loadup until subr.elc is loaded. What is awkward to do in C? Maybe I could help with that, so that we wouldn't need to move this to Lisp. Thanks.