From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Sun, 14 Nov 2021 20:04:19 +0200 Message-ID: <83lf1qtxzw.fsf@gnu.org> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> <87wnlya9sj.fsf@gnus.org> <86wnlbmooj.fsf@runbox.com> <83bl2nw723.fsf@gnu.org> <86tugen3q4.fsf@runbox.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6425"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gazally@runbox.com, larsi@gnus.org, 51037@debbugs.gnu.org To: Michael Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 14 19:05:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmJsi-0001Rw-1P for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 19:05:32 +0100 Original-Received: from localhost ([::1]:54264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmJsg-00016t-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 13:05:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmJsF-00014e-DJ for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 13:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmJsF-00059s-47 for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 13:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmJsE-00011E-WF for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 13:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Nov 2021 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.16369130813858 (code B ref 51037); Sun, 14 Nov 2021 18:05:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 14 Nov 2021 18:04:41 +0000 Original-Received: from localhost ([127.0.0.1]:51594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmJrs-000109-Ra for submit@debbugs.gnu.org; Sun, 14 Nov 2021 13:04:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmJrr-0000zw-80 for 51037@debbugs.gnu.org; Sun, 14 Nov 2021 13:04:39 -0500 Original-Received: from [2001:470:142:3::e] (port=60632 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmJrl-00057G-42; Sun, 14 Nov 2021 13:04:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/TMH0hreR6axAAH0AN9UTwVr8XTXue2UMn3R/f70UVA=; b=knsGPn6bfFtl zk+iKbwv0mmRt+/opV9nawZIvV52oReR20071F9U0Voj10ZCLrE5RKHDL3AIk/cBR1sxSt+EGODK6 NzJTbNZbngbkXaP5ZUu9+gWvJZuleR5fXMVFt2EsINy2JXL7vCz6kGRGTO5uxji44vcoElYgBQZ1B PJp9Gtxmry41Dt5zIKKjtIDeM+XNxqR0SWcW0+eGG4zCDQkiV3Q90e7OyIw1f+A1RnWurp+nvlAw3 USUdc8R57296tscnG5eJGXP7jjWdxabULrJSqW8VC9KPv9Xn760iN+ZmKoR9aAWGiwLGu9qWzGqRc UGlIStn7EpKbRZa71BrgHQ==; Original-Received: from [87.69.77.57] (port=4986 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmJrk-0005Ml-O8; Sun, 14 Nov 2021 13:04:33 -0500 In-Reply-To: <86tugen3q4.fsf@runbox.com> (message from Michael on Sun, 14 Nov 2021 07:42:27 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219990 Archived-At: > From: Michael > Cc: larsi@gnus.org, gazally@runbox.com, 51037@debbugs.gnu.org > Date: Sun, 14 Nov 2021 07:42:27 -0800 > > This commit introduces three new ert variables: > ert-batch-print-length, ert-batch-print-level & > ert-batch-backtrace-length. The first two control print-length ^^ Please leave 2 spaces between sentences, per our coding conventions (here and elsewhere in your patch). > +line lengths (i.e. to get full backtraces), or a positive integer to Either "i.e.," (with a comma), or "i.e.@:". Otherwise TeX will typeset "i.e." as if it ends a sentence. > +** New ERT batch variables > + > +Add three variables 'ert-batch-print-length', 'ert-batch-print-level' In NEWS we use a different style, like this: Three new variables 'ert-batch-print-length', ... IOW, "Add" is not appropriate here. > Backtrace mode will attempt to abbreviate printing of backtrace > -frames to make them shorter than this, but success is not > -guaranteed. If set to nil or zero, Backtrace mode will not > -abbreviate the forms it prints." > +frames by setting `print-level' & `print-length' to make them Please don't use "&" in doc strings; use "and" instead (here and elsewhere in the patch). > +shorter than this, but success is not guaranteed. If set to nil > +or zero, Backtrace mode will not abbreviate the forms it prints." ^^^^^^^^^ "backtrace", not capitalized/ > -(defun ert--setup-results-buffer (stats listener buffer-name) > +(defvar ert--output-buffer-name "*ert*") > + > +(defun ert--setup-results-buffer (stats listener) > "Set up a test results buffer. > > -STATS is the stats object; LISTENER is the results listener; > -BUFFER-NAME, if non-nil, is the buffer name to use." > - (unless buffer-name (setq buffer-name "*ert*")) > - (let ((buffer (get-buffer-create buffer-name))) > +STATS is the stats object; LISTENER is the results listener." > + (let ((buffer (get-buffer-create ert--output-buffer-name))) Why this change in the signature of the function?